feat: host tells client which IDs it uses for INetworkMessages #2103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… messages are absent (some tests do that)
0xFA11
reviewed
Aug 4, 2022
0xFA11
reviewed
Aug 4, 2022
0xFA11
reviewed
Aug 4, 2022
com.unity.netcode.gameobjects/Runtime/Messaging/MessagingSystem.cs
Outdated
Show resolved
Hide resolved
0xFA11
reviewed
Aug 4, 2022
com.unity.netcode.gameobjects/Runtime/Messaging/Messages/OrderingMessage.cs
Show resolved
Hide resolved
Co-authored-by: Fatih Mar <mfatihmar@gmail.com>
…ies/com.unity.multiplayer.mlapi into feat/message-id-ordering
jeffreyrainy
force-pushed
the
feat/message-id-ordering
branch
from
22e45ee to
fc0cd45
Compare
JesseOlmer
suggested changes
Aug 4, 2022
com.unity.netcode.gameobjects/Runtime/Messaging/MessagingSystem.cs
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Runtime/Messaging/MessagingSystem.cs
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Runtime/Messaging/MessagingSystem.cs
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Tests/Editor/Messaging/MessageRegistrationTests.cs
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Tests/Editor/Messaging/MessageRegistrationTests.cs
Show resolved
Hide resolved
JesseOlmer
reviewed
Aug 5, 2022
com.unity.netcode.gameobjects/Tests/Editor/Messaging/MessageRegistrationTests.cs
Show resolved
Hide resolved
JesseOlmer
reviewed
Aug 5, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…-Technologies#2103) Server sends client reordering messages when host and client have different sets to ensure proper handler mappings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a synchronization mechanism so that host tells client which IDs it uses for INetworkMessages. When there's discrepancies, allows the client to adjust its mapping.
Makes our SDK generally more robust.
Also necessary for https://jira.unity3d.com/browse/MTT-4166 since
2022.2has different classes visible in some scenario.