Skip to content

Conversation

jeffreyrainy
Copy link
Contributor

Fixed by doing the pre-write as a separate step

#2109
MTT-4386

Changelog

@jeffreyrainy jeffreyrainy requested a review from a team as a code owner August 17, 2022 03:41
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to make a test for this update?

@jeffreyrainy jeffreyrainy enabled auto-merge (squash) August 17, 2022 21:42
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffreyrainy jeffreyrainy merged commit 891bd67 into develop Aug 17, 2022
@jeffreyrainy jeffreyrainy deleted the fix/2109 branch August 17, 2022 22:34
jakobbbb pushed a commit to GooseGirlGames/com.unity.netcode.gameobjects that referenced this pull request Feb 22, 2023
…nity-Technologies#2128)

* fix: Fixed Owner-written NetworkVariable infinitely write themselves (Unity-Technologies#2109)
Fixed by doing the pre-write as a separate step

* nit PR review :-)

* Adding test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants