Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .yamato/vetting-test.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{% metadata_file .yamato/project.metafile %} # All configuration that is used to create different configurations (used in for loops) is taken from this file.
---
# DESCRIPTION--------------------------------------------------------------------------
# This configuration defines vetting tests for the Tools package which allows to validate if the package is in releasable state. This is important in particular because of API validation that allows to detect if we are introducing any new APIs that will force us to bump package version to new minor
# This configuration defines vetting tests for the NGO package which allows to validate if the package is in releasable state. This is important in particular because of API validation that allows to detect if we are introducing any new APIs that will force us to bump package version to new minor
# If this test fails with new API error we should either make those API internal OR bump package version to new minor (note that the package version reflects the current package state)

# Note that we are packing the package only (no project context) so if package have any soft dependencies then project should be used to test it (to enable those APIs)
{% for editor in validation_editors.minimal -%}
vetting_test:
name: MP Tools - Vetting Test (Win, {{editor}} LTS)
name: NGO - Vetting Test (Win, {{editor}} LTS)
agent: { type: Unity::VM, flavor: b1.large, image: package-ci/win11:v4 }
commands:
- npm install -g "upm-ci-utils@stable" --registry https://artifactory.prd.it.unity3d.com/artifactory/api/npm/upm-npm
Expand Down
2 changes: 1 addition & 1 deletion Tools/scripts/BuildAutomation/connect_services.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def main():
# Ensure the project is marked as connected
content = re.sub(r"cloudEnabled:.*", "cloudEnabled: 1", content)

with open(args.project_settings_path, 'w') as f:
with open(args.project_settings_path, 'w', encoding='UTF-8', newline='\n') as f:
f.write(content)

print(f"[Linker] Successfully updated {args.project_settings_path} with Project ID: {args.cloud_project_ID}, Org ID: {args.organization_ID}, Project Name: {args.project_name}")
Expand Down
4 changes: 2 additions & 2 deletions Tools/scripts/BuildAutomation/disable-enable-burst.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def create_config(settings_path):
}

data = {'MonoBehaviour': monobehaviour}
with open(config_name, 'w') as f:
with open(config_name, 'w', encoding='UTF-8', newline='\n') as f:
json.dump(data, f)
return config_name

Expand Down Expand Up @@ -87,7 +87,7 @@ def set_burst_AOT(config_file, status):
assert config is not None, 'AOT settings not found; did the burst-enabled build finish successfully?'

config['MonoBehaviour']['EnableBurstCompilation'] = status
with open(config_file, 'w') as f:
with open(config_file, 'w', encoding='UTF-8', newline='\n') as f:
json.dump(config, f)


Expand Down
2 changes: 1 addition & 1 deletion Tools/scripts/BuildAutomation/manifest_update.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def main():
local_path_normalized = args.local_package_path.replace(os.sep, '/')
manifest_data["dependencies"][args.package_name] = f"file:{local_path_normalized}"

with open(args.manifest_path, 'w') as f:
with open(args.manifest_path, 'w', encoding='UTF-8', newline='\n') as f:
json.dump(manifest_data, f, indent=4)

print(f"Successfully updated manifest at '{args.manifest_path}'")
Expand Down
4 changes: 2 additions & 2 deletions Tools/scripts/Utils/general_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def update_package_version_by_patch(package_manifest_path):

package_manifest['version'] = new_package_version

with open(package_manifest_path, 'w', encoding='UTF-8') as f:
with open(package_manifest_path, 'w', encoding='UTF-8', newline='\n') as f:
json.dump(package_manifest, f, indent=4)

return new_package_version
Expand Down Expand Up @@ -166,5 +166,5 @@ def update_changelog(changelog_path, new_version, add_unreleased_template=False)
)

# Write the changes
with open(changelog_path, 'w', encoding='UTF-8') as file:
with open(changelog_path, 'w', encoding='UTF-8', newline='\n') as file:
file.write(final_content)