chore: Optimize NetworkObject access from NetworkBehaviour #3687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When you will be ready you can ping me and I can organize the Playtest. Just note that I'm off next week |
| /// Invokes the <see cref="ChildNetworkBehaviours"/> <see cref="NetworkBehaviour.OnLostOwnership"/> and <see cref="NetworkBehaviour.OnGainedOwnership"/> events. | ||
| /// <see cref="NetworkSpawnManager.UpdateOwnershipTable"/> is called to update the ownership in-between the two callbacks. | ||
| /// </summary> | ||
| internal void InvokeBehaviourOnOwnershipChanged(ulong originalOwnerClientId, ulong newOwnerClientId) |
There was a problem hiding this comment.
Nicely done!
Collapsed, organized, and unified.
🥇
| { | ||
| networkObject.InvokeBehaviourOnGainedOwnership(); | ||
| } | ||
| // Notify lost ownership, update the ownership, then notify gained ownership for the network behaviours |
There was a problem hiding this comment.
Flex the unification!
| // Always notify locally on the server when a new owner is assigned | ||
| networkObject.InvokeBehaviourOnGainedOwnership(); | ||
| // Notify lost ownership, update the ownership, then notify gained ownership for the network behaviours | ||
| networkObject.InvokeBehaviourOnOwnershipChanged(originalOwner, clientId); |
| protected IEnumerator WaitForSpawnedOnAllOrTimeOut(NetworkObject networkObject, TimeoutHelper timeOutHelper = null) | ||
| { | ||
| var networkObjectId = networkObject.GetComponent<NetworkObject>().NetworkObjectId; | ||
| var networkObjectId = networkObject.NetworkObjectId; |
NoelStephensUnity
approved these changes
Sep 24, 2025
NoelStephensUnity
deleted the
chore/optimize-networkbehaviour-neworkobject-access
branch
NoelStephensUnity
added a commit
that referenced
this pull request
Sep 26, 2025
Changing #3687 adjustment to use the version of SpawnNetworkObjectLocally that accepts a SceneObject which doesn't invoke pre-spawn but does invoke post spawn and processes deferred messages. These were moved in this PR to assure post spawn was invoked after the object was 100% done locally spawning and as a last step process any deferred messages targeting this object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Methods inside of properties are much less performant to access that fields or methods without properties.
This PR focusses on:
NetworkBehaviour.NetworkObjectfrom withinNetworkBehaviour. Instead usingm_NetworkObjectanywhere that will be called after theNetworkBehaviouris spawned.a. Ensure that the
NetworkObjectexplicitly setsm_NetworkManagerwhen it calculates whether or not aNetworkBehaviourbelongs in it'sChildNetworkBehaviourslist.NetworkBehaviourlifecycle callbacks are invokeda. Simplifies the callsites around
NetworkBehaviour.OnLostOwnershipandNetworkBehaviour.OnGainedOwnershipb. Reduces loop duplication around
NetworkBehaviour.OnNetworkSpawnJira ticket
Link to related jira ticket (Use the smart commits). Short version (e.g. MTT-123) also works and gets auto-linked
to be created.
Changelog
NetworkBehaviourperformance.Documentation
Testing & QA (How your changes can be verified during release Playtest)
This change needs a full play of astroids, and potentially the OwnershipChanging demo. Everything here should be covered by the automated tests, but this is a hot enough codepath that playtesting is definitely needed here.
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
This is a pure performance improvement and so doesn't need a backport.