Skip to content

Conversation

vincentpierre
Copy link
Contributor

No description provided.

@xiaomaogy
Copy link
Contributor

We still have more than 5 places in the doc where we have .bytes file mentioned.

eg:

In Getting-Started-with-Balance-Ball.md, Learning-Environment-Executable.md, Training-Imitation-Learning.md.

@xiaomaogy
Copy link
Contributor

In test_demo_loader.py and test_trainer_controller.py, we still have Ball3DBrain mentioned.

You can press Ctrl+C to stop the training, and your trained model will be at
`models/<run-identifier>/editor_<academy_name>_<run-identifier>.bytes` where
`<academy_name>` is the name of the Academy GameObject in the current scene.
`models/<run-identifier>/<brain_name>.tf` where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we no longer put editor before the .tf file name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the brain_name directly

in various ways. The easiest way is to simply drag the file into the
**Project** window and drop it into an appropriate folder.
4. Once the `environment.bytes` file is imported, drag it from the **Project**
4. Once the `model_name .tf` file is imported, drag it from the **Project**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space here.

@xiaomaogy
Copy link
Contributor

In Using-TensorFlow-Sharp-in-Unity.md we still mention 'External Brain' in some places.

Copy link
Contributor

@xiaomaogy xiaomaogy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above are the things needs to be changed.

@xiaomaogy
Copy link
Contributor

In test_demo_loader.py and test_trainer_controller.py, we still have Ball3DBrain mentioned.

This is still not resolved.

@vincentpierre

@xiaomaogy
Copy link
Contributor

Once that's fixed it is good to be merged.

@vincentpierre
Copy link
Contributor Author

test_demo_loader.py is not related to documentation. It is just for tests.

@vincentpierre
Copy link
Contributor Author

The new docs refer to Inference-Engine.md that is not pushed. File can be seen here

@vincentpierre vincentpierre requested a review from eshvk October 12, 2018 23:57
Copy link
Contributor

@eshvk eshvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@vincentpierre vincentpierre merged commit 91cbec5 into release-v0.6 Oct 13, 2018
@vincentpierre vincentpierre deleted the release-v0.6-docs branch October 13, 2018 00:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants