-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Release v0.6 docs #1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.6 docs #1325
Conversation
We still have more than 5 places in the doc where we have .bytes file mentioned. eg: In Getting-Started-with-Balance-Ball.md, Learning-Environment-Executable.md, Training-Imitation-Learning.md. |
In test_demo_loader.py and test_trainer_controller.py, we still have Ball3DBrain mentioned. |
You can press Ctrl+C to stop the training, and your trained model will be at | ||
`models/<run-identifier>/editor_<academy_name>_<run-identifier>.bytes` where | ||
`<academy_name>` is the name of the Academy GameObject in the current scene. | ||
`models/<run-identifier>/<brain_name>.tf` where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we no longer put editor before the .tf file name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use the brain_name directly
in various ways. The easiest way is to simply drag the file into the | ||
**Project** window and drop it into an appropriate folder. | ||
4. Once the `environment.bytes` file is imported, drag it from the **Project** | ||
4. Once the `model_name .tf` file is imported, drag it from the **Project** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space here.
In Using-TensorFlow-Sharp-in-Unity.md we still mention 'External Brain' in some places. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above are the things needs to be changed.
In test_demo_loader.py and test_trainer_controller.py, we still have Ball3DBrain mentioned. This is still not resolved. |
Once that's fixed it is good to be merged. |
test_demo_loader.py is not related to documentation. It is just for tests. |
The new docs refer to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.