Skip to content

Conversation

harper-u3d
Copy link
Contributor

This PR fixes a few minor issues with documentation from the release-v0.6 branch:

  • In Migrating.md, the steps to migrate and change log were combined. I separated them and added a step on migrating the Academy.
  • In Background-Tensorflow.md we referred to an external tutorial on Tensorflow but didn't mention our own guide, which I've linked.
  • Minor capitalization fix in Background-Machine-Learning.md

Copy link
Contributor

@eshvk eshvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for most of the changes, I'd like Vince to take a look at the migration steps once more, they look good but would like a second pair of eyes.

@harperj harperj changed the base branch from release-v0.6 to develop November 13, 2018 18:35
@harperj harperj changed the title Develop v06 doc updates v0.6 docs minor updates Nov 13, 2018
* Agents have a `Brain` field in the Inspector, you need to drag the
appropriate Brain ScriptableObject in it.
* The Academy has a `Broadcast Hub` field in the inspector, which is
list of brains used in the scene. You need to drag all `Brain`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The broadcast hub does not need to have all of the brains present in the scene. Only the ones that need to be broadcasted or controlled by the Python process.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, forgot that you gave me this feedback in person. Reworded this.

@vincentpierre
Copy link
Contributor

🚢 🇮🇹

@harperj harperj merged commit d2be7b6 into develop Nov 15, 2018
harperj pushed a commit that referenced this pull request Nov 15, 2018
* Capitalization fix for ML background docs

* Reference our Tensorboard docs from Background-Tensorflow

* Separate v0.6 migration steps from change list

* Migration doc feedback tweak

* Updated Broadcast Hub doc
@vincentpierre vincentpierre deleted the develop-v06-doc-updates branch December 14, 2018 21:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants