Skip to content

Clarify normalization for vectors #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2020
Merged

Clarify normalization for vectors #3654

merged 1 commit into from
Mar 20, 2020

Conversation

chriselion
Copy link
Contributor

@chriselion chriselion commented Mar 19, 2020 •
edited
Loading

Proposed change(s)

I think the section on normalization might incorrectly lead users to use Vector3.normalized, which would not give good results.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

https://forum.unity.com/threads/is-it-possible-to-have-an-agent-know-about-something-rather-than-be-curious-all-the-time.848563/#post-5602306

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@chriselion chriselion requested review from awjuliani and ervteng March 19, 2020 01:34
awjuliani
awjuliani approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@awjuliani awjuliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@chriselion chriselion merged commit 6a11071 into master Mar 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the Clarify-normalization-for-vectors branch March 20, 2020 18:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ervteng ervteng Awaiting requested review from ervteng

1 more reviewer

@awjuliani awjuliani awjuliani approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriselion @awjuliani