Skip to content

Update Changelog and test #6246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2025
Merged

Update Changelog and test #6246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba65683
Update Changelog
maryamziaa Sep 17, 2025
90baefc
Add space
maryamziaa Sep 17, 2025
dac39a7
Update tests
maryamziaa Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions com.unity.ml-agents/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to
[Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Minor Changes
#### com.unity.ml-agents (C#)
- Fixed tensor indexing to use correct CHW layout (#6239)

#### ml-agents / ml-agents-envs
- Fixed CUDA/CPU mismatch in threaded training (#6245)

## [4.0.0] - 2025-08-15
### Major Changes
#### com.unity.ml-agents (C#)
Expand Down
20 changes: 8 additions & 12 deletions com.unity.ml-agents/Tests/Editor/Integrations/Match3/Match3SensorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,8 @@ public void TestVisualObservations(bool fullBoard)
{
expectedObs = new float[]
{
1, 0, /**/ 0, 1, /**/ 1, 0,
1, 0, /**/ 1, 0, /**/ 1, 0,
1, 0, /**/ 1, 0, /**/ 1, 0,
// NCHW layout: [channel0_all_positions, channel1_all_positions]
1, 0, 1, 1, 1, 1, 1, 1, 1, 0, 1, 0, 0, 0, 0, 0, 0, 0
};

expectedObs3D = new float[,,]
Expand All @@ -158,9 +157,8 @@ public void TestVisualObservations(bool fullBoard)
{
expectedObs = new float[]
{
1, 0, /* 0 */ 0, 1, /* 1 */ 0, 0, /* empty */
1, 0, /* 0 */ 1, 0, /* 0 */ 0, 0, /* empty */
0, 0, /* empty */ 0, 0, /* empty */ 0, 0, /* empty */
// NCHW layout: [channel0_all_positions, channel1_all_positions]
1, 0, 0, 1, 1, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0
};

expectedObs3D = new float[,,]
Expand Down Expand Up @@ -201,9 +199,8 @@ public void TestVisualObservationsSpecial()

var expectedObs = new float[]
{
1, 0, /* (0) */ 0, 1, /* (1) */ 1, 0, /* (0) */
1, 0, /* (0) */ 1, 0, /* (0) */ 1, 0, /* (0) */
1, 0, /* (0) */ 1, 0, /* (0) */ 1, 0, /* (0) */
// NCHW layout: [channel0_all_positions, channel1_all_positions]
1, 0, 1, 1, 1, 1, 1, 1, 1, 0, 1, 0, 0, 0, 0, 0, 0, 0
};
SensorTestHelper.CompareObservation(cellSensor, expectedObs);

Expand Down Expand Up @@ -238,9 +235,8 @@ public void TestVisualObservationsSpecial()

var expectedObs = new float[]
{
1, 0, 0, /* (0) */ 1, 0, 0, /* (1) */ 1, 0, 0, /* (0) */
0, 0, 1, /* (2) */ 1, 0, 0, /* (0) */ 1, 0, 0, /* (0) */
1, 0, 0, /* (0) */ 0, 1, 0, /* (1) */ 1, 0, 0, /* (0) */
// NCHW layout: [channel0_all_positions, channel1_all_positions, channel2_all_positions]
1, 1, 1, 0, 1, 1, 1, 0, 1, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0
};
SensorTestHelper.CompareObservation(specialSensor, expectedObs);

Expand Down