-
Notifications
You must be signed in to change notification settings - Fork 128
Add torque control to urscript #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add torque control to urscript #325
Conversation
5575a26
to
9e60359
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## torque_control #325 +/- ##
=================================================
Coverage ? 83.04%
=================================================
Files ? 1
Lines ? 230
Branches ? 0
=================================================
Hits ? 191
Misses ? 39
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9e60359
to
2adb339
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thank you very much for contributing this!
I mainly have two points at this stage:
- In my opinion it would be better to use
torque
instead oftau
for readability. I added my perspective inside the first occurrence. Would you agree with that? - Second, we've added an interface to set the friction compensation parameter on and off in #323, so we can use that in the
torque_command
call directly.
Co-authored-by: Felix Exner <feex@universal-robots.com>
Wonderful, that's neat! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for implementing and contributing this!
The PR adds
MODE_TORQUE
to the supported control modes and extends the external control urscript with a torque thread that applies the latestcmd_tau
as torque command.torque_command
also has an optional parameterfriction_comp
that might be worth parametrizing too, but I'm not sure what effect that had in the first place so I went hardcoded for an MVP.Let me know what you think about this and what might still be missing.