Skip to content

Conversation

domire8
Copy link
Contributor

@domire8 domire8 commented May 19, 2025

The PR adds MODE_TORQUE to the supported control modes and extends the external control urscript with a torque thread that applies the latest cmd_tau as torque command.

torque_command also has an optional parameter friction_comp that might be worth parametrizing too, but I'm not sure what effect that had in the first place so I went hardcoded for an MVP.

Let me know what you think about this and what might still be missing.

@domire8 domire8 changed the base branch from master to torque_control May 19, 2025 07:22
@domire8 domire8 force-pushed the feat/torque-control branch from 5575a26 to 9e60359 Compare May 19, 2025 07:23
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (torque_control@ebe30d2). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             torque_control     #325   +/-   ##
=================================================
  Coverage                  ?   83.04%           
=================================================
  Files                     ?        1           
  Lines                     ?      230           
  Branches                  ?        0           
=================================================
  Hits                      ?      191           
  Misses                    ?       39           
  Partials                  ?        0           
Flag Coverage Δ
start_ursim 83.04% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@domire8 domire8 force-pushed the feat/torque-control branch from 9e60359 to 2adb339 Compare May 19, 2025 07:24
Copy link
Member

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you very much for contributing this!

I mainly have two points at this stage:

  • In my opinion it would be better to use torque instead of tau for readability. I added my perspective inside the first occurrence. Would you agree with that?
  • Second, we've added an interface to set the friction compensation parameter on and off in #323, so we can use that in the torque_command call directly.

Co-authored-by: Felix Exner <feex@universal-robots.com>
@domire8
Copy link
Contributor Author

domire8 commented May 20, 2025

Second, we've added an interface to set the friction compensation parameter on and off in #323, so we can use that in the torque_command call directly.

Wonderful, that's neat!

Copy link
Member

@urfeex urfeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for implementing and contributing this!

@urfeex urfeex merged commit 01761be into UniversalRobots:torque_control May 20, 2025
7 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants