Skip to content

v0.0.24 — the share page, after a browser looked at it

Choose a tag to compare

@Urdemonlord Urdemonlord released this 18 Nov 12:25
· 9 commits to master since this release

v0.0.24 — What four screenshots found

v0.0.23 shipped a share page. It passed 24 shell checks and looked finished in
curl output. Then it was opened in Chromium at 390 px and 1100 px, and four
things were wrong that no shell check could see.

1. The summary line was invisible, and the disk path was public

The file count and total size went into <title>, so a visitor saw a page with
a wordmark and no explanation. Worse, the <title> was built from the share
directory, so /var/tmp/acme/secret — the operator's path — was rendered into a
page served to whoever held the link.

- let summary = format!("{} file(s), {} — {}", …, root.display());
+ let summary = format!("{} file(s), {}", …);          // no path, ever
+ &format!("<p>{summary}</p><table>{body}</table>")   // visible, where a human reads

2. 4 file(s)

file(s) is what you write when you cannot be bothered. Two branches, four
lines:

let summary = match rows.len() {
    1 => format!("1 file, {}", crate::human_bytes(total)),
    n => format!("{n} files, {}", crate::human_bytes(total)),
};

3. A path was indistinguishable from a file name

A nested file kept its relative path — sub/catatan-rapat-produk.txt — inline,
same size, same colour except a dimmed prefix. On a phone that wrapped mid-name,
and it read as one filename that happens to contain a slash. Colour alone as the
only cue also fails WCAG 1.4.1.

The folder now gets its own line above the name, smaller and dimmer; the
structure carries the meaning, not the hue.

4. The download arrow slid around

↓ 1.1 MiB, ↓ 293.0 KiB, ↓ 14 B were one right-aligned run, so the arrow
sat at a different x in every row and the eye caught a ragged edge. Two fixed
slots — glyph, then a fixed-width right-aligned number — put all four arrows on
one axis.

What was checked

  • cargo build --release clean; 15 unit, 31 compat, 28 json, 25 pull-resume,
    29 hosts, 19 pull, 17 resume, 52 fan-out, 25 sync, 24 page
    — 265 checks, all
    green; daemon e2e run separately, no failures
  • the page was rendered by real Chromium (headless, in the sandbox — nothing
    installed on the production host) at phone and desktop width, and re-read from
    the resulting PNGs after every fix

What is not claimed

  • The page has not been exercised on a real Windows kernel. WinPE has no
    curl.exe, so the HTML cannot be fetched from inside the VM. What is
    checked is the shipped .exe itself, running under wine in the sandbox:

    $ zapsend.exe --version          -> zapsend 0.0.24
    $ GET /            (no PIN)      -> the PIN form
    $ GET /?pin=4242                 -> <p>2 files, 4.0 KiB</p>, blob.bin, sub/ label
    $ leaked paths in the page       -> 0
    $ GET download link              -> sha256 matches the source file
    

    wine is not Windows: this proves the binary and the HTML it serves, not the
    kernel.

  • No bulk "download all", no file-type icons, no desktop-specific layout. A
    share page for a handful of files does not need them; the empty space on a
    wide screen is honest about how little there is to show.