Switches for accessibility information #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What I miss in this pull request is the actual 'result structure' for example I want to know what happens if the realtime status would not be available. |
|
@skinkie To answer your question as I understand it: IncludeAccessFeatureStatus (in this PR) is used to request or not real time information about access features. As for the result, see PR #238 - there is AccessFeatureStatus (and AccessFeatureStatusText and SituationFullRef) to provide the real time status. If some data is not available, this can be signalled using AccessFeatureWithUnknownAvailability. Additionally, there is the problem code TRIP_REALTIMEINCOMPLETE that could be used, It should probably also be used by TripRefineRequest, shouldn't it? |
sgrossberndt
force-pushed
the
changes_for_v1.1
branch
from
0f6cda8
to
0e21b03
Compare
# Conflicts: # docs/generated/index.html
# Conflicts: # docs/generated/index.html
skinkie
previously approved these changes
Jan 20, 2023
skinkie
previously approved these changes
Jan 20, 2023
sgrossberndt
requested changes
Jan 20, 2023
sgrossberndt
approved these changes
Jan 20, 2023
skinkie
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the meeting: adding the ability (OJP_TripRequest) to specify the accessibility-related information to return as it may differ depending on the user profile and on what data will be used and presented.