Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since OpenROM has experimental support for gf180mcuD, I think it would be useful to have a test to make sure it does not break in the future.
This PR adds one config for:
gf180mcu_rom_1kbyte
.For now, I disabled
check_lvsdrc
for gf180mcu as it seems the magic version installed via conda is too old.Maybe the tools/PDK versions that OpenRAM uses can be updated in the future.
Also, when writing rom_data, it makes sure that the output directory exists.
I created the variable
lef_rom_interconnect
to specify the metal layers for lef writing.Maybe you know a better name for it ;)