Merge pull request #2311 from VWS-Python/replace-read-getvalue

Replace `read` with `getvalue` where possible

Author: adamtheturtle

tests/mock_vws/fixtures/prepared_requests.py

@@ -45,7 +45,7 @@ def add_target(
     """
     Return details of the endpoint for adding a target.
     """
-    image_data = image_file_failed_state.read()
+    image_data = image_file_failed_state.getvalue()
     image_data_encoded = base64.b64encode(s=image_data).decode(
         encoding="ascii"
     )
@@ -431,7 +431,7 @@ def query(
     """
     Return details of the endpoint for making an image recognition query.
     """
-    image_content = high_quality_image.read()
+    image_content = high_quality_image.getvalue()
     date = rfc_1123_date()
     request_path = "/v1/query"
     files = {"image": ("image.jpeg", image_content, "image/jpeg")}

tests/mock_vws/test_add_target.py

@@ -145,7 +145,7 @@ def test_content_types(
         """
         Any non-empty ``Content-Type`` header is allowed.
         """
-        image_data = image_file_failed_state.read()
+        image_data = image_file_failed_state.getvalue()
         image_data_encoded = base64.b64encode(s=image_data).decode(
             encoding="ascii"
         )
@@ -173,7 +173,7 @@ def test_empty_content_type(
         An ``UNAUTHORIZED`` response is given if an empty ``Content-Type``
         header is given.
         """
-        image_data = image_file_failed_state.read()
+        image_data = image_file_failed_state.getvalue()
         image_data_encoded = base64.b64encode(s=image_data).decode(
             encoding="ascii"
         )
@@ -219,7 +219,7 @@ def test_missing_data(
         """
         `name`, `width` and `image` are all required.
         """
-        image_data = image_file_failed_state.read()
+        image_data = image_file_failed_state.getvalue()
         image_data_encoded = base64.b64encode(s=image_data).decode(
             encoding="ascii",
         )
@@ -261,7 +261,7 @@ def test_width_invalid(
         """
         The width must be a number greater than zero.
         """
-        image_data = image_file_failed_state.read()
+        image_data = image_file_failed_state.getvalue()
         image_data_encoded = base64.b64encode(s=image_data).decode(
             encoding="ascii"
         )
@@ -369,7 +369,7 @@ def test_name_invalid(
         A target's name must be a string of length 0 < N < 65, with characters
         in a particular range.
         """
-        image_data = image_file_failed_state.read()
+        image_data = image_file_failed_state.getvalue()
         image_data_encoded = base64.b64encode(s=image_data).decode(
             encoding="ascii",
         )
@@ -709,7 +709,7 @@ def test_valid(
         """
         Boolean values and NULL are valid active flags.
         """
-        image_data = image_file_failed_state.read()
+        image_data = image_file_failed_state.getvalue()
         image_data_encoded = base64.b64encode(s=image_data).decode(
             encoding="ascii",
         )
@@ -739,7 +739,7 @@ def test_invalid(
         Values which are not Boolean values or NULL are not valid active flags.
         """
         active_flag = "string"
-        image_data = image_file_failed_state.read()
+        image_data = image_file_failed_state.getvalue()
         image_data_encoded = base64.b64encode(s=image_data).decode(
             encoding="ascii"
         )
@@ -773,7 +773,7 @@ def test_not_set(
         """
         The active flag defaults to True if it is not set.
         """
-        image_data = image_file_failed_state.read()
+        image_data = image_file_failed_state.getvalue()
         image_data_encoded = base64.b64encode(s=image_data).decode(
             encoding="ascii"
         )
@@ -798,7 +798,7 @@ def test_set_to_none(
         """
         The active flag defaults to True if it is set to NULL.
         """
-        image_data = image_file_failed_state.read()
+        image_data = image_file_failed_state.getvalue()
         image_data_encoded = base64.b64encode(s=image_data).decode(
             encoding="ascii"
         )
@@ -832,7 +832,7 @@ def test_invalid_extra_data(
         """
         A `BAD_REQUEST` response is returned when unexpected data is given.
         """
-        image_data = image_file_failed_state.read()
+        image_data = image_file_failed_state.getvalue()
         image_data_encoded = base64.b64encode(s=image_data).decode(
             encoding="ascii"
         )
@@ -897,7 +897,7 @@ def test_null(
         """
         NULL is valid application metadata.
         """
-        image_data = image_file_failed_state.read()
+        image_data = image_file_failed_state.getvalue()
         image_data_encoded = base64.b64encode(s=image_data).decode(
             encoding="ascii"
         )
@@ -925,7 +925,7 @@ def test_invalid_type(
         Values which are not a string or NULL are not valid application
         metadata.
         """
-        image_data = image_file_failed_state.read()
+        image_data = image_file_failed_state.getvalue()
         image_data_encoded = base64.b64encode(s=image_data).decode(
             encoding="ascii"
         )