Document how to use blocks with lambda slots #1318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camertron
approved these changes
Mar 28, 2022
|
Thanks for the approval, @camertron. Any thoughts on how we can get the Lint check passing? |
joelhawksley
requested changes
Mar 31, 2022
There was a problem hiding this comment.
@sampart would you be willing to add a test for this use case? I think it would be helpful to verify that the documentation we are adding is 1) correct and 2) remains correct ❤️
Co-authored-by: Joel Hawksley <joel@hawksley.org>
Co-authored-by: Joel Hawksley <joel@hawksley.org>
sampart
added a commit
that referenced
this pull request
Apr 12, 2022
|
@sampart sorry about that lint check, I fixed it in master and merged the change into this branch. Should be good to go now. |
Co-authored-by: Joel Hawksley <joel@hawksley.org>
|
@joelhawksley sorry for the delay; I've now added a test in 625c7d7. I hope it's the kind of thing you were intending. Thanks |
joelhawksley
approved these changes
Apr 20, 2022
|
Thank you! |
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Dec 22, 2023
* Document how to use blocks with lambda slots * Update CHANGELOG * Add self to contributors list * Remove trailing whitespace * Wording tweaks from code review Co-authored-by: Joel Hawksley <joel@hawksley.org> * Pass block to content_tag differently Co-authored-by: Joel Hawksley <joel@hawksley.org> * Add test for providing lambda slot content via block ViewComponent#1318 (review) * Update doc test to match altered sample code Co-authored-by: Joel Hawksley <joel@hawksley.org> * Fix linter violation * Apply suggestions from code review Co-authored-by: Cameron Dutro <camertron@gmail.com> Co-authored-by: Joel Hawksley <joel@hawksley.org>
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Jan 3, 2024
* Document how to use blocks with lambda slots * Update CHANGELOG * Add self to contributors list * Remove trailing whitespace * Wording tweaks from code review Co-authored-by: Joel Hawksley <joel@hawksley.org> * Pass block to content_tag differently Co-authored-by: Joel Hawksley <joel@hawksley.org> * Add test for providing lambda slot content via block ViewComponent#1318 (review) * Update doc test to match altered sample code Co-authored-by: Joel Hawksley <joel@hawksley.org> * Fix linter violation * Apply suggestions from code review Co-authored-by: Cameron Dutro <camertron@gmail.com> Co-authored-by: Joel Hawksley <joel@hawksley.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds documentation for how to render block content in a lambda slot.
It may just be that I'm a relative ruby newbie, but this felt like a gap in the documentation to me. It's also very different to how component slots do it, since the
contentmethod isn't available.Other Information
As requested in https://github.com/github/view_component/blob/main/docs/CONTRIBUTING.md#submitting-a-pull-request, I've added this change to the CHANGELOG and my avatar to the docs, even though this change is very minor. But I won't be offended if you deem neither of those changes necessary for such a small PR 😸