Package form: Dont expand all release notes

Author: ollydev

Source/ide/simba.form_package.lfm

@@ -1,49 +1,49 @@
 object SimbaPackageForm: TSimbaPackageForm
   Left = -1860
-  Height = 550
+  Height = 962
   Top = 325
-  Width = 782
+  Width = 1368
   Caption = 'Simba Packages'
-  ClientHeight = 0
-  ClientWidth = 0
-  Constraints.MinHeight = 250
-  Constraints.MinWidth = 250
-  OnShow = FormShow
+  ClientHeight = 962
+  ClientWidth = 1368
+  Constraints.MinHeight = 438
+  Constraints.MinWidth = 438
+  DesignTimePPI = 168
   Position = poMainFormCenter
   ShowInTaskBar = stAlways
-  LCLVersion = '3.8.0.0'
+  OnShow = FormShow
   object Notebook1: TNotebook
     Left = 0
-    Height = 477
+    Height = 873
     Top = 0
-    Width = 782
+    Width = 1368
     PageIndex = 0
     Align = alClient
     TabOrder = 0
     object MainPage: TPage
       object ListPanel: TPanel
         Left = 0
-        Height = 314
+        Height = 550
         Top = 0
-        Width = 782
+        Width = 1368
         Align = alTop
         BevelOuter = bvNone
         TabOrder = 0
       end
       object BottomNotebook: TNotebook
         Left = 0
-        Height = 158
-        Top = 319
-        Width = 782
+        Height = 314
+        Top = 559
+        Width = 1368
         PageIndex = 0
         Align = alClient
         TabOrder = 1
         object PageVersions: TPage
           object ScrollBox1: TScrollBox
             Left = 0
-            Height = 158
+            Height = 314
             Top = 0
-            Width = 782
+            Width = 1368
             HorzScrollBar.Increment = 1
             HorzScrollBar.Page = 1
             HorzScrollBar.Smooth = True
@@ -66,16 +66,16 @@ object SimbaPackageForm: TSimbaPackageForm
             Top = 12
             Width = 954
             Align = alClient
-            BorderSpacing.Around = 10
-            Font.Height = -10
+            BorderSpacing.Around = 18
+            Font.Height = -18
             Font.Name = 'Courier New'
             Font.Pitch = fpFixed
             Font.Quality = fqCleartypeNatural
             ParentColor = False
             ParentFont = False
             TabOrder = 0
             Gutter.Visible = False
-            Gutter.Width = 53
+            Gutter.Width = 84
             Gutter.MouseActions = <>
             RightGutter.Width = 0
             RightGutter.MouseActions = <>
@@ -118,11 +118,13 @@ object SimbaPackageForm: TSimbaPackageForm
             LineHighlightColor.Foreground = clNone
             inline SynLeftGutterPartList1: TSynGutterPartList
               object SynGutterMarks1: TSynGutterMarks
-                Width = 24
+                Width = 42
                 MouseActions = <>
+                MaxExtraMarksColums = 0
+                Options = [sgmoDeDuplicateMarksOnOverflow]
               end
               object SynGutterLineNumber1: TSynGutterLineNumber
-                Width = 13
+                Width = 23
                 MouseActions = <>
                 MarkupInfo.Background = clBtnFace
                 MarkupInfo.Foreground = clNone
@@ -132,18 +134,19 @@ object SimbaPackageForm: TSimbaPackageForm
                 LeadingZeros = False
               end
               object SynGutterChanges1: TSynGutterChanges
-                Width = 4
+                Width = 7
                 MouseActions = <>
                 ModifiedColor = 59900
                 SavedColor = clGreen
               end
               object SynGutterSeparator1: TSynGutterSeparator
-                Width = 2
+                Width = 4
                 MouseActions = <>
                 MarkupInfo.Background = clWhite
                 MarkupInfo.Foreground = clGray
               end
               object SynGutterCodeFolding1: TSynGutterCodeFolding
+                Width = 18
                 MouseActions = <>
                 MarkupInfo.Background = clNone
                 MarkupInfo.Foreground = clGray
@@ -159,9 +162,9 @@ object SimbaPackageForm: TSimbaPackageForm
             Width = 954
             Align = alBottom
             AutoSize = True
-            BorderSpacing.Left = 10
-            BorderSpacing.Right = 10
-            BorderSpacing.Bottom = 10
+            BorderSpacing.Left = 18
+            BorderSpacing.Right = 18
+            BorderSpacing.Bottom = 18
             Caption = 'Installing...'
             TabOrder = 1
             OnClick = InstallingButtonClick
@@ -171,9 +174,9 @@ object SimbaPackageForm: TSimbaPackageForm
       object Splitter1: TSplitter
         Cursor = crVSplit
         Left = 0
-        Height = 5
-        Top = 314
-        Width = 782
+        Height = 9
+        Top = 550
+        Width = 1368
         Align = alTop
         ResizeAnchor = akTop
       end
@@ -184,9 +187,9 @@ object SimbaPackageForm: TSimbaPackageForm
         AnchorSideLeft.Side = asrCenter
         AnchorSideTop.Control = LoadingPage
         AnchorSideTop.Side = asrCenter
-        Left = 256
+        Left = 448
         Height = 25
-        Top = 235
+        Top = 411
         Width = 339
         Caption = 'Downloading package list. Please wait...'
         Font.Style = [fsBold]
@@ -197,21 +200,21 @@ object SimbaPackageForm: TSimbaPackageForm
   end
   object PanelBottom: TPanel
     Left = 0
-    Height = 73
-    Top = 477
-    Width = 782
+    Height = 89
+    Top = 873
+    Width = 1368
     Align = alBottom
     Anchors = [akLeft, akBottom]
     AutoSize = True
     BevelOuter = bvNone
-    ClientHeight = 73
-    ClientWidth = 782
+    ClientHeight = 89
+    ClientWidth = 1368
     TabOrder = 1
     object Bevel3: TBevel
       Left = 0
-      Height = 2
+      Height = 4
       Top = 0
-      Width = 782
+      Width = 1368
       Align = alTop
       Shape = bsTopLine
     end
@@ -220,24 +223,24 @@ object SimbaPackageForm: TSimbaPackageForm
       AnchorSideLeft.Side = asrCenter
       AnchorSideTop.Control = Bevel3
       AnchorSideTop.Side = asrBottom
-      Left = 288
-      Height = 71
-      Top = 2
-      Width = 206
+      Left = 560
+      Height = 85
+      Top = 4
+      Width = 248
       AutoSize = True
       BevelOuter = bvNone
-      ClientHeight = 71
-      ClientWidth = 206
+      ClientHeight = 85
+      ClientWidth = 248
       TabOrder = 0
       object ToolBar: TToolBar
         Left = 0
-        Height = 67
-        Top = 2
-        Width = 206
+        Height = 77
+        Top = 4
+        Width = 248
         Align = alBottom
         AutoSize = True
-        BorderSpacing.Top = 2
-        BorderSpacing.Bottom = 2
+        BorderSpacing.Top = 4
+        BorderSpacing.Bottom = 4
         ButtonHeight = 0
         ButtonWidth = 0
         EdgeBorders = []
@@ -258,15 +261,15 @@ object SimbaPackageForm: TSimbaPackageForm
           OnClick = ButtonRefreshClick
         end
         object ButtonAddRepository: TToolButton
-          Left = 73
+          Left = 95
           Top = 0
           AutoSize = True
           Caption = 'Add Repository'
           ImageIndex = 0
           OnClick = ButtonAddRepositoryClick
         end
         object ToolButton1: TToolButton
-          Left = 67
+          Left = 81
           Height = 0
           Top = 0
           Caption = 'ToolButton1'
@@ -278,8 +281,8 @@ object SimbaPackageForm: TSimbaPackageForm
   object ImageList36: TImageList
     Height = 36
     Width = 36
-    Left = 32
-    Top = 70
+    Left = 56
+    Top = 123
     Bitmap = {
       4C7A010000002400000024000000600800000000000078DAED987B70D4D515C7
       3710A80F04A90F6CA342AB88D882A88D552A6865C0A90E2D4C41A42204228F52
@@ -354,8 +357,8 @@ object SimbaPackageForm: TSimbaPackageForm
   object ImageList: TImageList
     Height = 32
     Width = 32
-    Left = 32
-    Top = 134
+    Left = 56
+    Top = 235
     Bitmap = {
       4C7A020000002000000020000000980900000000000078DAED98095055E715C7
       BFF79E3C4529221AC749B489D692E8683560A78D1347DCADD1AA89BBB86F0DAE

Source/ide/simba.ide_package_components.pas

@@ -65,6 +65,7 @@     TVersionHeader = class
       Age: String;
     end;
     TVersionInfo = class
+      Expanded: Boolean;
       Notes: String;
       Wrapped: TStringArray;
     end;
@@ -74,6 +75,9 @@     TVersionInfo = class
     FFixedCharWidth: Integer;
     FFixedCharHeight: Integer;
 
+    // forward scroll events
+    function DoMouseWheel(Shift: TShiftState; WheelDelta: Integer; MousePos: TPoint): Boolean; override;
+    procedure MouseUp(Button: TMouseButton; Shift: TShiftState; X,Y: Integer); override;
     procedure FontChanged(Sender: TObject); override;
 
     procedure DoOnResize; override;
@@ -572,6 +576,38 @@ procedure TPackageInfoGrid.SetInfo(HomepageURL, InstalledVer, LatestVer: String)
   Cells[1, 3] := LatestVer;
 end;
 
+function TPackageVersionGrid.DoMouseWheel(Shift: TShiftState; WheelDelta: Integer; MousePos: TPoint): Boolean;
+begin
+  Result := inherited DoMouseWheel(Shift, WheelDelta, MousePos);
+  if (Parent is TScrollBox) then
+    TScrollBox(Parent).VertScrollBar.Position := TScrollBox(Parent).VertScrollBar.Position - WheelDelta;
+end;
+
+procedure TPackageVersionGrid.MouseUp(Button: TMouseButton; Shift: TShiftState; X, Y: Integer);
+var
+  ColIndex, RowIndex: Integer;
+  Data: TObject;
+begin
+  inherited MouseUp(Button, Shift, X, Y);
+
+  MouseToCell(X, Y, ColIndex, RowIndex);
+  Data := Objects[ColIndex, RowIndex];
+  if (Data is TVersionInfo) then
+  begin
+    BeginUpdate();
+    try
+      if TVersionInfo(Data).Expanded then
+        RowHeights[RowIndex] := FFixedCharHeight + varCellpadding
+      else
+        RowHeights[RowIndex] := (Length(TVersionInfo(Data).Wrapped) * FFixedCharHeight) + varCellPadding;
+      TVersionInfo(Data).Expanded := not TVersionInfo(Data).Expanded;
+      Height := GridHeight;
+    finally
+      EndUpdate();
+    end;
+  end;
+end;
+
 procedure TPackageVersionGrid.FontChanged(Sender: TObject);
 begin
   inherited FontChanged(Sender);
@@ -627,11 +663,19 @@ procedure TPackageVersionGrid.DrawCellText(aCol, aRow: Integer; aRect: TRect; aS
     Inc(ARect.Top, varCellPadding div 2);
     Inc(ARect.Left, varCellPadding);
 
-    for Line in Info.Wrapped do
+    if Info.Expanded then
     begin
-      Canvas.TextOut(ARect.Left, ARect.Top, Line.TrimRight());
+      for Line in Info.Wrapped do
+      begin
+        Canvas.TextOut(ARect.Left, ARect.Top, Line.TrimRight());
 
-      Inc(ARect.Top, FFixedCharHeight);
+        Inc(ARect.Top, FFixedCharHeight);
+      end;
+    end
+    else begin
+      Canvas.Font.Underline := True;
+      Canvas.TextOut(ARect.Left, ARect.Top, 'View notes');
+      Canvas.Font.Underline := False;
     end;
 
     Exit;
@@ -680,7 +724,7 @@ constructor TPackageVersionGrid.Create(AOwner: TComponent);
   GridLineWidth := 0;
   AutoFillColumns := True;
   ScrollBars := ssNone;
-  Enabled := False;
+  Enabled := True;
 
   FixedCols := 0;
   FixedRows := 1;
@@ -790,18 +834,23 @@ procedure TPackageVersionGrid.DoLineWrapping(Foo: PtrInt);
     begin
       Data := Objects[0, I];
 
-      if Data is TVersionInfo then
+      if (Data is TVersionInfo) then
       begin
         Info.Wrapped := UTF8WrapText(Info.Notes, MaxCol).Split(LineEnding);
 
-        RowHeights[I] := (Length(Info.Wrapped) * FFixedCharHeight) + varCellPadding;
+        // Have the first one always expanded
+        if (I = FixedRows+1) then
+        begin
+          RowHeights[I] := (Length(TVersionInfo(Data).Wrapped) * FFixedCharHeight) + varCellpadding;
+          TVersionInfo(Data).Expanded := True;
+        end else
+          RowHeights[I] := FFixedCharHeight + varCellpadding;
       end;
     end;
+    Height := GridHeight;
   finally
     EndUpdate();
   end;
-
-  Height := GridHeight;
 end;
 
 procedure TPackageVersionGrid.DoFontCalculate;