-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding load mitigating controls and OWC #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for developing this application case @dforbush2
I have reviewed the documentation and I have run the cases on my laptop with no issues. The documentation is well detailed and easy to follow. This PR is ready to merge.
Hey @dforbush2 A couple comments before merging: OWC:
Both OWC and Load Mitigating Control:
|
Hi @akeeste
|
@dforbush2 There's a ton of other test fixes in #49. So as long as tests for these cases can pass, the rest should work once merged in dev. |
Looks like I still need a test for the load mit controls...it also looks like the tests I wrote for the OWC don't actually run in the unit tests, so I could use some help here with the unit test code. |
@dforbush2 I'll take a look at the test files and push/PR to your branch if possible. |
@dforbush2 I made updates for these tests. See dforbush2#1. Once that PR is merged into your branch, we can merge this PR into WEC-Sim Apps |
Updates for PR 39
Merged dev into this branch to resolve conflicts. I will merge once the tests pass |
@dforbush2 The Load Mitigating Control and OWC tests are passing, so i will merge this PR. @kmruehl The MOST test is not passing, apparently because of some small numerical differences. There is an optimization routine for some of the pre-processing files, I'm guessing there is some variation in the optimization outcome, which is slightly changing the end results (on the order of 0.01%). A couple ideas: we could add the pre-processed files to the repo and test based on those inputs, and then afterwards test that the pre-processing steps work, or decrease the accuracy required by the tests |
* Adding load mitigating controls and OWC (#39) * Adding load mitigating controls * adding OWC applications case example * adding 2020b version * adding hydroData source * update readmes, linting * adding OWC orifice data * add h5 file, mod gitignore, add testOWC * add LMC and OWC tests to CI * add LMC and OWC tests * remove R2020b simulink file, remove last LTI block * remove extra library file * fix some paths, toolboxes required by the tests * fix issue from merging dev, remove paraview tests * add OWC MCR case to tests --------- Co-authored-by: akeeste <akeeste@sandia.gov> * Common input files (#50) * common RM3 hydroData and geometry * common OSWEC hydroData and geometry files * multiple wave headings * update input files * consolidate sphere hydrodata * update input files * revert nonlinear hydro files back to original * fix tests * remove outdated comments from input files * Increase test tolerance (#51) * Increase test tolerance * Change to relative tolerances * Increase relative tolerance for tower * Update README.md (#52) Co-authored-by: Kelley Ruehl <kmruehl@sandia.gov> --------- Co-authored-by: dforbush2 <dforbus@sandia.gov> Co-authored-by: akeeste <akeeste@sandia.gov> Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com> Co-authored-by: Kelley Ruehl <kmruehl@sandia.gov>
This is an updated applications case from https://marineenergyjournal.org/imej/article/view/68 updated to WEC-Sim v5.0. It works. Documentation is included.
Also included the OWC orifice example from OREC training reworked slightly for applications case