Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for WEC-Sim Applications #49

Merged
merged 18 commits into from
Oct 18, 2023
Merged

Bug fixes for WEC-Sim Applications #49

merged 18 commits into from
Oct 18, 2023

Conversation

akeeste
Copy link
Contributor

@akeeste akeeste commented Oct 16, 2023

Final round of bug fixes for WEC-Sim Applications before v6.0 release:

  • update MOST pre-processing
    • Remove calls to clearvars and convert mostIO scripts to functions to prevent variable conflicts
    • Remove TurbSim executable. WEC-Sim shouldn't ship another independent software within it
  • add Multiple Wave Headings test and standardize naming within it
  • update the call to tiledlayout in WECCCOMP MPC post processing to work with R2020b
  • make paths in the MOST test OS-agnostic
  • switch tests to windows --> revert back to linux and instead remove MoorDyn for now. The .so file will be updated at a later date
    • remove all MoorDyn Tests: Paraview and Mooring
  • Remove 2020b tests, update all tests to latest version of MATLAB only
  • All tests pass

@akeeste akeeste mentioned this pull request Oct 16, 2023
@kmruehl kmruehl self-requested a review October 16, 2023 19:51
@kmruehl kmruehl added the bug label Oct 16, 2023
@akeeste
Copy link
Contributor Author

akeeste commented Oct 17, 2023

@jtgrasb @RyanDavies19 MoorDyn 2.0 is now being tested on Linux through GitHub actions. But it seems like the .so file is causing MATLAB to crash. Do either of you have insight? Has the .so been tested locally?

@akeeste
Copy link
Contributor Author

akeeste commented Oct 17, 2023

Test update: There are three failing tests (each on both MATLAB versions with the same errors):

  • Mooring (MoorDyn case) --> .so file is causing MATLAB to crash?
  • Paraview (MoorDyn case) --> .so file is causing MATLAB to crash?
  • MOST --> Adam will check and update here

@jtgrasb
Copy link
Contributor

jtgrasb commented Oct 17, 2023

Hi Adam,

I apologize for the issues with the .so file. I was able to generate the .so file using the HPC machines, but i wasn't able to test it. Do you know if there's anyone on the WEC-Sim team that uses a linux machine and can generate and test a new .so file?

@kmruehl
Copy link
Contributor

kmruehl commented Oct 17, 2023

Decision to switch tests to run on Windows, and remove *.so file from the MoorDyn repo. Running MoorDyn on Linux will be added to the project board to be resolved after v6 release.

relates to WEC-Sim/MoorDyn#4

Copy link
Contributor

@kmruehl kmruehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good, but we're still having issues with a few of the tests. Those need to be resolved prior to merging

@kmruehl
Copy link
Contributor

kmruehl commented Oct 18, 2023

tests are passing! merging now

@kmruehl kmruehl merged commit 27ff16e into WEC-Sim:dev Oct 18, 2023
21 checks passed
@akeeste akeeste deleted the testFixes3 branch November 1, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants