-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes for WEC-Sim Applications #49
Conversation
@jtgrasb @RyanDavies19 MoorDyn 2.0 is now being tested on Linux through GitHub actions. But it seems like the |
Test update: There are three failing tests (each on both MATLAB versions with the same errors):
|
Hi Adam, I apologize for the issues with the .so file. I was able to generate the .so file using the HPC machines, but i wasn't able to test it. Do you know if there's anyone on the WEC-Sim team that uses a linux machine and can generate and test a new .so file? |
Decision to switch tests to run on Windows, and remove *.so file from the MoorDyn repo. Running MoorDyn on Linux will be added to the project board to be resolved after v6 release. relates to WEC-Sim/MoorDyn#4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good, but we're still having issues with a few of the tests. Those need to be resolved prior to merging
tests are passing! merging now |
Final round of bug fixes for WEC-Sim Applications before v6.0 release:
clearvars
and convert mostIO scripts to functions to prevent variable conflictstiledlayout
in WECCCOMP MPC post processing to work with R2020blatest
version of MATLAB only