Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window.anonymous usage in the wild #1

Closed
miketaylr opened this issue Mar 28, 2022 · 7 comments
Closed

window.anonymous usage in the wild #1

miketaylr opened this issue Mar 28, 2022 · 7 comments

Comments

@miketaylr
Copy link

Have y'all done any analysis of how common window.anonymous is on the web, maybe via HTTP Archive?

A quick search finds https://github.com/firebase/firebase-js-sdk/search?q=window.anonymous&type=code, which might create some confusing test errors down the road. Not sure that's a deal-breaker, but just flagging for awareness.
@ArthurSonzogni
Copy link
Collaborator

ArthurSonzogni commented Mar 28, 2022 •
edited
Loading

Thanks!

Initially, this was document.anonymous, but we realized during the implementation that this was more a property of the window instead of its documents. See: camillelamy/explainers#21

We can still expose document.anonymous and say it returns the document`s responsible window (if any) anonymous attribute.

I will run an HTTP archive query and put the result here once it is known. Thanks again for raising this potential issue!

@ArthurSonzogni
Copy link
Collaborator

Here is the public HTTP archive analysis:
https://docs.google.com/document/d/1MKGUfGzEEKpll88QspKiwDRWdkOMVh3OOXSrxGWe1Y4/edit#
Summary:

  • 33 origins are serving a script containing window.anonymous toward 223 origins. ~80% of the subresources are coming from https://player.gotolstoy.com/.
  • 1 origin is serving itself a script containing document.anonymous.

@ArthurSonzogni
Copy link
Collaborator

We are going to update to a more uncommon name: window.isAnonymousFramed.

@miketaylr
Copy link
Author

Sounds good, thanks!

@ArthurSonzogni
Copy link
Collaborator

(keeping this open, up until it gets fixed in the spec and the implementation)

@mikewest
Copy link
Member

Grammar nit: isAnonymouslyFramed sounds better to me. :)

Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 6, 2022
@iVanlIsh @chromium-wpt-export-bot
[Anonymous Iframe] Change window.anonymous to window.isAnonymouslyFramed
a565d56 
Since there's a bunch of usage of window.anonymous in various of origins
currently in the world, we decide to change the naming to a more precise
and un-confusing `isAnonymouslyFramed`. See more:
WICG/anonymous-iframe#1

Bug: 1323180
Change-Id: I81637cdb004e87408235edb9b367062f62358577
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 6, 2022
@iVanlIsh @chromium-wpt-export-bot
[Anonymous Iframe] Change window.anonymous to window.isAnonymouslyFramed
b30c5ef 
Since there's a bunch of usage of window.anonymous in various of origins
currently in the world, we decide to change the naming to a more precise
and un-confusing `isAnonymouslyFramed`. See more:
WICG/anonymous-iframe#1

Bug: 1323180
Change-Id: I81637cdb004e87408235edb9b367062f62358577
iVanlIsh added a commit to iVanlIsh/explainers that referenced this issue May 6, 2022
@iVanlIsh
Update window.anonymous to window.isAnonymouslyFramed
70378d1 
As discussed in WICG/anonymous-iframe#1, we updated the name of the attribute to `window.isAnonymouslyFramed`.
TODO(lyf): update the image.
iVanlIsh added a commit to iVanlIsh/anonymous-iframe that referenced this issue May 6, 2022
@iVanlIsh
Update window.anonymous to window.isAnonymouslyFramed
3ef8dd6 
As discussed in WICG#1, we updated the name of the attribute to `window.isAnonymouslyFramed`.
This was referenced May 6, 2022
Merged
Open
aarongable pushed a commit to chromium/chromium that referenced this issue May 6, 2022
@iVanlIsh
[Anonymous Iframe] Change window.anonymous to window.isAnonymouslyFramed
8048aa8 
Since there's a bunch of usage of window.anonymous in various of origins
currently in the world, we decide to change the naming to a more precise
and un-confusing `isAnonymouslyFramed`. See more:
WICG/anonymous-iframe#1

Bug: 1323180
Change-Id: I81637cdb004e87408235edb9b367062f62358577
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3613772
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Yifan Luo <lyf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000496}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 6, 2022
@iVanlIsh @chromium-wpt-export-bot
[Anonymous Iframe] Change window.anonymous to window.isAnonymouslyFramed
315fe04 
Since there's a bunch of usage of window.anonymous in various of origins
currently in the world, we decide to change the naming to a more precise
and un-confusing `isAnonymouslyFramed`. See more:
WICG/anonymous-iframe#1

Bug: 1323180
Change-Id: I81637cdb004e87408235edb9b367062f62358577
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3613772
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Yifan Luo <lyf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000496}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 6, 2022
@iVanlIsh @chromium-wpt-export-bot
[Anonymous Iframe] Change window.anonymous to window.isAnonymouslyFramed
7cd897f 
Since there's a bunch of usage of window.anonymous in various of origins
currently in the world, we decide to change the naming to a more precise
and un-confusing `isAnonymouslyFramed`. See more:
WICG/anonymous-iframe#1

Bug: 1323180
Change-Id: I81637cdb004e87408235edb9b367062f62358577
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3613772
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Yifan Luo <lyf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000496}
ArthurSonzogni pushed a commit that referenced this issue May 9, 2022
@iVanlIsh
Update window.anonymous to window.isAnonymouslyFramed (#3)
871f5da 
As discussed in #1, we updated the name of the attribute to `window.isAnonymouslyFramed`.
@ArthurSonzogni
Copy link
Collaborator

Resolved in both Chrome and the specification thanks to @iVanlIsh

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 16, 2022
@iVanlIsh @moz-wptsync-bot
Bug 1768167 [wpt PR 33962] - [Anonymous Iframe] Change window.anonymo…
9973fc5 
…us to window.isAnonymouslyFramed, a=testonly

Automatic update from web-platform-tests
[Anonymous Iframe] Change window.anonymous to window.isAnonymouslyFramed

Since there's a bunch of usage of window.anonymous in various of origins
currently in the world, we decide to change the naming to a more precise
and un-confusing `isAnonymouslyFramed`. See more:
WICG/anonymous-iframe#1

Bug: 1323180
Change-Id: I81637cdb004e87408235edb9b367062f62358577
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3613772
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Yifan Luo <lyf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000496}

--

wpt-commits: 7cd897fb1c5c0b29a2d7460c8b3f8638f4142aee
wpt-pr: 33962
jamienicol pushed a commit to jamienicol/gecko that referenced this issue May 25, 2022
@iVanlIsh @moz-wptsync-bot
Bug 1768167 [wpt PR 33962] - [Anonymous Iframe] Change window.anonymo…
ad98351 
…us to window.isAnonymouslyFramed, a=testonly

Automatic update from web-platform-tests
[Anonymous Iframe] Change window.anonymous to window.isAnonymouslyFramed

Since there's a bunch of usage of window.anonymous in various of origins
currently in the world, we decide to change the naming to a more precise
and un-confusing `isAnonymouslyFramed`. See more:
WICG/anonymous-iframe#1

Bug: 1323180
Change-Id: I81637cdb004e87408235edb9b367062f62358577
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3613772
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Yifan Luo <lyf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000496}

--

wpt-commits: 7cd897fb1c5c0b29a2d7460c8b3f8638f4142aee
wpt-pr: 33962
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
@iVanlIsh @copybara-github
[Anonymous Iframe] Change window.anonymous to window.isAnonymouslyFramed
656bf7b 
Since there's a bunch of usage of window.anonymous in various of origins
currently in the world, we decide to change the naming to a more precise
and un-confusing `isAnonymouslyFramed`. See more:
WICG/anonymous-iframe#1

Bug: 1323180
Change-Id: I81637cdb004e87408235edb9b367062f62358577
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3613772
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Yifan Luo <lyf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000496}
NOKEYCHECK=True
GitOrigin-RevId: 8048aa846d48d42dc88b3cc85f6f8e6b1931685a
@ArthurSonzogni ArthurSonzogni mentioned this issue Nov 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikewest @miketaylr @ArthurSonzogni