Skip to content

feat(CRater): Ping endpoint #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 29, 2025
Merged

feat(CRater): Ping endpoint #304

merged 8 commits into from
May 29, 2025

Conversation

@Aaron-Detre
Copy link
Contributor

@Aaron-Detre Aaron-Detre commented May 12, 2025

Changes

  • Receives ping requests from the client for various "berkeley_" item IDs, and only continues if the item ID is not in the cache (meaning it has already been pinged recently).
  • If the item ID is not in the cache, the item ID is cached for 4 minutes and 40 seconds and a real ping for that item ID is sent to the Berkeley endpoint.

Test

  • Make sure that ~30 seconds after focusing on a "berkeley_" item ID that hasn't been used recently, scoring requests come back quickly without the cold start waiting time.
  • Requires this PR for the Client.

@Aaron-Detre Aaron-Detre self-assigned this May 12, 2025
@Aaron-Detre Aaron-Detre mentioned this pull request May 12, 2025
Merged
@Aaron-Detre Aaron-Detre changed the title Ping endpoint feat(CRater): Ping endpoint May 12, 2025
@Aaron-Detre Aaron-Detre added the enhancement New feature or request label May 12, 2025
@Aaron-Detre Aaron-Detre marked this pull request as ready for review May 13, 2025 18:34
hirokiterashima
hirokiterashima approved these changes May 29, 2025
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hirokiterashima hirokiterashima merged commit b937771 into develop May 29, 2025
3 checks passed
@hirokiterashima hirokiterashima deleted the ping-endpoint branch May 29, 2025 18:52
@hirokiterashima
Copy link
Member

hirokiterashima commented May 29, 2025

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@Aaron-Detre Aaron-Detre

Labels

enhancement New feature or request released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Aaron-Detre @hirokiterashima