Skip to content

feat(Grade by step): Display component summary views #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 152 commits into from
Sep 11, 2025
Merged

feat(Grade by step): Display component summary views #2090

merged 152 commits into from
Sep 11, 2025

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Feb 12, 2025 •
edited by breity
Loading

Changes

This PR adds summaries for each component in a step in a set of tabs. Each component shows the prompt and completion %. Some components also show summary data (Multiple Choice, Match, items with idea detection enabled, any items with scores). It adds a select drop-down to choose which components to view in the student work view.

Test

Choose a step in the Grade-by-step view. It should show the summary view for the first component in the step.

Verify the following:

  • Step completion and step mean score should be displayed at the top of the page
  • If the step has multiple components, you should see a select drop-down, and this will let you switch between the components.
  • If the component has a summary display (e.g. choices chosen on a MC component), it should show the summary view.
  • If the component has scores, it should show the score distributions in the summary view panel
  • Sort the student list by team/status/score
  • Expand and collapse each student, and expand all students and collapse all students
  • See students' work for the component, and provide scores and comments
  • (for @breity)
    • Milestone grading view works as before
    • PeerChat component shows Peer Grouping button
    • Milestone component shows Report button

Closes #2099

@hirokiterashima
index on component-grading: 994bbd9 refactor(ViewComponentRevisionsCo…
5398178 
…mponent): Convert to standalone (#2018)
@hirokiterashima
Add ComponentGradingComponent
654a9f8
@hirokiterashima
feat(NodeGrading): add SelectComponentComponent
d1e4169
@hirokiterashima
feat(NodeGrading): enhance component with teacher summary displays
b8b5c70
@hirokiterashima
Merge branch 'develop' into grade-by-component
62a975d
@hirokiterashima
Navigate to node/group routes when current node changes.
39fad25
@hirokiterashima
Switching components now correctly renders the summary for the new co…
f9fe066 
…mponents.
@hirokiterashima
Update summary display when period selection is changed.
9ba1137
@hirokiterashima
refactor(NodeGradingComponent, SelectComponentComponent): update comp…
675a289 
…onent structure to use components array instead of node
@hirokiterashima
feat(ComponentGradingView): add new component for grading components
d1aa2ca
@hirokiterashima
Merge branch 'develop' into grade-by-component
5a51ed8
@hirokiterashima
feat(NodeGradingComponent): replace methods with properties for node …
ecd56b1 
…average score and completion percentage
@hirokiterashima
Merge branch 'develop' into grade-by-component
a82e7b3
@hirokiterashima
Merge branch 'develop' into grade-by-component
6a4cdfa
@hirokiterashima
Merge branch 'develop' into grade-by-component
51b2874
@hirokiterashima
Merge branch 'develop' into grade-by-component
8c80503
@hirokiterashima
Merge branch 'develop' into grade-by-component
357087d
@hirokiterashima
Merge branch 'develop' into grade-by-component
8ef340c
@hirokiterashima
Merge branch 'develop' into grade-by-component
37ecffc
@hirokiterashima
Merge branch 'develop' into grade-by-component
9e17164
@hirokiterashima hirokiterashima self-assigned this Feb 12, 2025
@hirokiterashima
Add ClassResponses to show student work on a specific component. Got …
d79b647 
…it to work for some components like OR and MC. Had to comment out some component grading modules in ComponentGradingComponent because they cause multiple instances of TeacherDataService to be created
@hirokiterashima
Uncommented out all the component grading modules in ComponentGrading…
d15d7bc 
…Component and got the Grading Tool to work without having to instantiate multiple TeacherDataServices
@hirokiterashima
Merge branch 'develop' into grade-by-component
b554863
@hirokiterashima
Fix issue where the ClassResponses was not being rendered for the ver…
a6981ca 
…y first time the NodeGradingComponent was initialized
@hirokiterashima
Show component score and max score when ComponentWorkgroupItem is ini…
89242a6 
…tialized
@hirokiterashima
Calculate score in ClassResponsesComponent and pass down to Component…
09df026 
…WorkgroupItemComponent
@hirokiterashima
Component completion status display is now working
9002a59
@hirokiterashima
Add "Step" to completion and mean score heading text
695f3f5
@hirokiterashima
Get events when getting student data for node. This is used to calcul…
90f5ae7 
…ate component completion.
qltysh[bot]
qltysh bot reviewed Sep 10, 2025
View reviewed changes
qltysh[bot]
qltysh bot reviewed Sep 10, 2025
View reviewed changes
qltysh[bot]
qltysh bot reviewed Sep 10, 2025
View reviewed changes
...classroomMonitor/classroomMonitorComponents/component-summary/component-summary.component.ts
.getCRaterRubric(this.node.id, this.component.id)
.hasRubricData();
this.hasSummaryData =
(this.component?.type === 'MultipleChoice' && this.hasStudentWork) ||
Copy link

@qltysh qltysh bot Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complex binary expression [qlty:boolean-logic]

...classroomMonitor/classroomMonitorComponents/component-summary/component-summary.component.ts
.hasRubricData();
this.hasSummaryData =
(this.component?.type === 'MultipleChoice' && this.hasStudentWork) ||
(this.hasScoresSummary && this.hasScoreAnnotation) ||
Copy link

@qltysh qltysh bot Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complex binary expression [qlty:boolean-logic]

qltysh[bot]
qltysh bot reviewed Sep 10, 2025
View reviewed changes
qltysh[bot]
qltysh bot reviewed Sep 11, 2025
View reviewed changes
qltysh[bot]
qltysh bot reviewed Sep 11, 2025
View reviewed changes
src/assets/wise5/classroomMonitor/classroomMonitorComponents/AbstractClassResponsesComponent.ts
Comment on lines +24 to +30
constructor(
protected annotationService: AnnotationService,
protected classroomStatusService: ClassroomStatusService,
protected configService: ConfigService,
protected dataService: TeacherDataService,
protected notificationService: NotificationService,
protected projectService: TeacherProjectService
Copy link

@qltysh qltysh bot Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): constructor [qlty:function-parameters]

...assroomMonitor/classroomMonitorComponents/grading-step-tools/grading-step-tools.component.ts
Comment on lines 38 to +44
constructor(
protected dataService: TeacherDataService,
protected dir: Directionality,
protected nodeService: GradingNodeService,
protected projectService: TeacherProjectService
protected projectService: TeacherProjectService,
private route: ActivatedRoute,
private router: Router
Copy link

@qltysh qltysh bot Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): constructor [qlty:function-parameters]

...lassroomMonitorComponents/nodeGrading/node-class-responses/node-class-responses.component.ts
Comment on lines +41 to +48
constructor(
protected annotationService: AnnotationService,
protected classroomStatusService: ClassroomStatusService,
private componentServiceLookupService: ComponentServiceLookupService,
protected configService: ConfigService,
protected dataService: TeacherDataService,
protected notificationService: NotificationService,
protected projectService: TeacherProjectService
Copy link

@qltysh qltysh bot Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 7): constructor [qlty:function-parameters]

.../classroomMonitorComponents/nodeGrading/node-workgroup-item/node-workgroup-item.component.ts
Comment on lines +128 to +157
private updateStatus(): void {
switch (this.status) {
case -1:
this.statusClass = ' ';
this.statusText = $localize`Not Assigned`;
break;
case 2:
this.statusClass = 'success';
if (this.nodeHasWork) {
this.statusText = $localize`Completed`;
} else {
this.statusText = $localize`Visited`;
}
break;
case 1:
this.statusClass = 'text';
this.statusText = $localize`Partially Completed`;
break;
default:
this.statusClass = 'text-secondary';
if (this.nodeHasWork) {
this.statusText = $localize`No Work`;
} else {
this.statusText = $localize`Not Visited`;
}
}
if (this.hasNewAlert) {
this.statusClass = 'warn';
}
this.disabled = this.status === -1;
Copy link

@qltysh qltysh bot Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 31 lines of similar code in 3 locations (mass = 146) [qlty:similar-code]

src/assets/wise5/directives/student-summary-display/student-summary-display.component.ts
Comment on lines 32 to 38
constructor(
protected annotationService: AnnotationService,
protected configService: ConfigService,
protected cRaterService: CRaterService,
protected dataService: StudentDataService,
protected projectService: ProjectService,
protected summaryService: SummaryService
Copy link

@qltysh qltysh bot Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): constructor [qlty:function-parameters]

...ts/wise5/directives/teacher-summary-display/ideas-summary-display/ideas-summary.component.ts
Comment on lines 44 to 51
constructor(
protected annotationService: AnnotationService,
protected configService: ConfigService,
private cRaterService: CRaterService,
protected cRaterService: CRaterService,
protected dataService: TeacherDataService,
private ideasSortingService: IdeasSortingService,
protected projectService: TeacherProjectService,
protected summaryService: SummaryService
Copy link

@qltysh qltysh bot Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 7): constructor [qlty:function-parameters]

src/assets/wise5/directives/teacher-summary-display/teacher-summary-display.component.ts
Comment on lines 25 to 31
constructor(
protected annotationService: AnnotationService,
protected configService: ConfigService,
protected cRaterService: CRaterService,
protected dataService: TeacherDataService,
protected projectService: ProjectService,
protected projectService: TeacherProjectService,
protected summaryService: SummaryService
Copy link

@qltysh qltysh bot Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): constructor [qlty:function-parameters]

breity
breity approved these changes Sep 11, 2025
View reviewed changes
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go. 🚀

@hirokiterashima hirokiterashima changed the title feat(Grade by component): allow teachers to grade by component feat(Grade by step): Display component summary views Sep 11, 2025
@hirokiterashima hirokiterashima merged commit c133ed4 into develop Sep 11, 2025
4 checks passed
@hirokiterashima hirokiterashima deleted the grade-by-component branch September 11, 2025 21:39
@hirokiterashima
Copy link
Member Author

hirokiterashima commented Sep 11, 2025

🎉 This PR is included in version 5.196.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qltysh qltysh[bot] qltysh[bot] left review comments

@Aaron-Detre Aaron-Detre Aaron-Detre requested changes

@breity breity breity approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels

enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(Grading Tool): Grade by component

4 participants

@hirokiterashima @breity @Aaron-Detre