Skip to content

fix(Unit Library): redesign fixes #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 21, 2025
Merged

fix(Unit Library): redesign fixes #2152

merged 4 commits into from
Apr 21, 2025

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Apr 21, 2025

Changes

  • Clear filter on destroy. This makes unit library appear with all the units at the beginning each time it's loaded
  • Update display in filters when items are selected for Features and UnitTypes
  • Move LibraryFilterComponent.hasFilters() to ProjectFilterValues

@hirokiterashima hirokiterashima added the bug Something isn't working label Apr 21, 2025
@hirokiterashima hirokiterashima self-assigned this Apr 21, 2025
@hirokiterashima hirokiterashima marked this pull request as ready for review April 21, 2025 22:56
@hirokiterashima hirokiterashima merged commit d8f2bd8 into develop Apr 21, 2025
5 of 6 checks passed
@hirokiterashima hirokiterashima deleted the unit-library-redesign-fixes-2025 branch April 21, 2025 23:12
@hirokiterashima
Copy link
Member Author

hirokiterashima commented Apr 21, 2025

🎉 This PR is included in version 5.177.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@hirokiterashima hirokiterashima

Labels

bug Something isn't working released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hirokiterashima