Skip to content

Conversation

@breity
Copy link
Member

@breity breity commented May 23, 2025

Changes

  • Removes "Archive" option for Public library units.

Test

  1. Go to homepage, scroll down to Curriculum Offerings.
  2. Click on units in the library.
  3. In the unit details pop-up, click on the three dot menu. Make sure the "Archive" option is not shown.
  4. Sign in as a teacher and go to /curriculum and complete step 3 for Public units.
  5. Select the My Units tab.
  6. Click on any of the units in My Units, click on the three dot menu, and make sure that the "Archive" option is shown.

Closes #2187.

@breity breity requested a review from hirokiterashima May 23, 2025 19:13
@breity breity self-assigned this May 23, 2025
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good, but 2 unit tests are failing. Can you fix the tests before merge?

1) shows archive button
     LibraryProjectMenuComponent project does not have archived tag
     TypeError: Cannot read properties of undefined (reading 'publicUnitType')
2) shows restore button
     LibraryProjectMenuComponent project has archived tag
     TypeError: Cannot read properties of undefined (reading 'publicUnitType')

@breity breity merged commit 8b1cdc6 into develop May 28, 2025
6 checks passed
@breity breity deleted the issue-2187-public-units-have-archive-option branch May 28, 2025 22:53
@hirokiterashima
Copy link
Member

🎉 This PR is included in version 5.187.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Library): Public units have Archive option

3 participants