This repository was archived by the owner on Sep 24, 2018. It is now read-only.
#347: Added filters to taxonomy based on get_terms args. #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -215,7 +215,34 @@ public function get_taxonomy_terms( $taxonomy ) { | |||
| $args = array( | |||
| 'hide_empty' => false, | |||
| ); | |||
|
|
|||
|
|
|||
| // Allow args in get_terms function, a common sense list... | |||
There was a problem hiding this comment.
A common-sense list, or a full list of what's available to get_terms? Since we can't pull this from a WP internal list like we do with filter parameters, I feel it's good to be specific about whether this is a full or partial list, and (if partial) what the differences are.
…e of taxonomy filter.
|
Okay, committed update per @kadamwhite's suggestions. Thx! |
|
This appears to work as advertised, @rmccue. I can provide get_terms filters e.g. |
rmccue
added a commit
that referenced
this pull request
Oct 26, 2014
#347: Added filters to taxonomy based on get_terms args.
|
Sorry for the super long review time on this one, just got time to get back to it with @kadamwhite's help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #347.