Weston's review #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix ArrayAccess params
…ture/weston-review Conflicts: lib/infrastructure/class-wp-rest-server.php
|
@rmccue @rachelbaker There, that's it for my initial review. |
| public function jsonSerialize() { | ||
| // @codingStandardsIgnoreEnd |
There was a problem hiding this comment.
This one has to be ignored for WPCS, otherwise it throws a naming error, last I checked?
There was a problem hiding this comment.
Not since February: WordPress/WordPress-Coding-Standards#307
|
I'm Commander Shepard, and this is my favourite PR on the repo. 👍 |
rachelbaker
added a commit
to WP-API/WP-API
that referenced
this pull request
Oct 3, 2015
|
Merged into WP-API/WP-API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this PR to document things I think should (or could) be changed. I'm not necessarily intending this PR to be merged wholesale, but some of its commits can be cherry-picked.
I can also squash the commits together once feedback is provided.