Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing sidebar from single-post single-column template #1292

Merged
merged 8 commits into from
Sep 12, 2016

Conversation

rclations
Copy link

fixes #1104

The single one column template states that it does not load any sidebars, however the included content-single.php partial does load a sidebar, which appears as an accidental mini-left-sidebar.

The parent ticket (#1104) suggested moving the sidebar to the right and making it wider, but then it would only be a clone of the two-column layout.

Another option would be to move the sidebar below the post content in the single column, and restyle so it appears naturally after the content.

I'm definitely open to thoughts & suggestions for how we'd like to tackle this. For now, I've removed the sidebar entirely, since that's what's already documented in the single-one-column.php file.

@rclations
Copy link
Author

for reference, this is what the accidental sidebar looks like -

screen shot 2016-09-07 at 5 04 30 pm

@aschweigert
Copy link

The docblock is wrong, unfortunately. I'll find an example of what this should look like, but it does need to be retained.

@aschweigert
Copy link

here's an example: http://wisconsinwatch.org/2016/09/wisconsin-must-do-more-to-protect-residents-from-lead-in-drinking-water-dnr-and-milwaukee-leaders-agree/

But here, oddly, it's on the right (where it always should have been). I'm not sure if something got screwed up when this was folded into the Largo parent theme and it's still correct in this child theme or what. But that's closer to how it's actually being used in practice by a few sites.

@aschweigert
Copy link

hm, on the other hand...maybe that's something they're just dropping into the body of the post directly. but that's generally what we'd be looking for here.

@rclations
Copy link
Author

How about something like this?
(Twitter card is an iframe, so not much can be done there)

screen shot 2016-09-08 at 3 23 27 pm

@@ -210,7 +210,7 @@
}
}
.single.normal #sidebar .widget {
padding: 0 @baseline 0 0;
padding: 0 (@baseline / 2);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will also affect the two column layout (i think) so we may not want to do this...maybe

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think .normal is the class for our one-column layout, with .classic the two-column class, but I may be wrong here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, ok that might be right (if not very clear)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, that's the case

@aschweigert
Copy link

Couple small things, otherwise the lgtm for now. In a perfect world we'd probably make this sidebar a little wider and either push it into the body of the content and/or out into the gutter. @Julia67 do you have any thoughts on this? I'm ok with punting for now if we don't want to mess with it. This doesn't get used too often anyway.

@aschweigert aschweigert merged commit cbbf2b8 into WPBuddy:develop Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants