Skip to content

Conversation

@Mygod
Copy link
Collaborator

@Mygod Mygod commented Sep 25, 2025

Fixes #947. I couldn't test this one either so summoning testers. @kamieniarz @nileplumb @prof-miles0 @Shyvadi

Token usage: total=174,962 input=151,324 (+ 3,689,216 cached) output=23,638 (reasoning 14,912)
To continue this session, run codex resume 01997f21-2a4c-7cc0-b4e5-df3f069eb4fb.

@Mygod Mygod requested a review from Shyvadi September 25, 2025 04:42
@Mygod Mygod added the Enhancement New feature or request label Sep 25, 2025
@Mygod Mygod changed the title feat: cooldown bypass feat: cooldown bypass for scan on demand Sep 25, 2025
@kamieniarz
Copy link
Contributor

kamieniarz commented Sep 25, 2025

Works great with discord, thanks!

@Mygod Mygod requested a review from Copilot September 25, 2025 06:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements cooldown bypass functionality for scanner modes, allowing certain roles to skip cooldown restrictions when using scan-on-demand features. The changes add a new permission system that determines which scanner modes should bypass cooldowns based on user roles and provider type.

Key changes:

  • Added scannerCooldownBypass function to determine bypass permissions
  • Enhanced mergePerms utility to handle merging of both existing and incoming permission keys
  • Integrated cooldown bypass logic into scanner configuration and execution

Reviewed Changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
server/src/utils/scannerPerms.js Adds new scannerCooldownBypass function to determine bypass permissions
server/src/utils/mergePerms.js Enhances permission merging to handle cases where keys exist in only one object
server/src/services/TelegramClient.js Integrates cooldown bypass permissions for Telegram users
server/src/services/LocalClient.js Adds cooldown bypass support for local authentication
server/src/services/DiscordClient.js Implements cooldown bypass permissions for Discord users
server/src/routes/rootRouter.js Initializes empty cooldown bypass array in settings
server/src/graphql/resolvers.js Implements cooldown bypass logic in scanner configuration and execution
config/default.json Adds cooldown bypass configuration structure
config/custom-environment-variables.json Defines environment variables for cooldown bypass settings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Mygod Mygod marked this pull request as ready for review September 25, 2025 06:48
@Mygod
Copy link
Collaborator Author

Mygod commented Sep 26, 2025

Everyone else: if you tested and it is working well, please also leave a note so I can know. :)

@nileplumb
Copy link

nileplumb commented Sep 26, 2025 via email

@Mygod Mygod merged commit 9ceefef into WatWowMap:develop Nov 20, 2025
4 checks passed
@Mygod Mygod deleted the cooldown-bypass branch November 20, 2025 20:03
github-actions bot pushed a commit that referenced this pull request Nov 20, 2025
# [1.40.0-develop.28](v1.40.0-develop.27...v1.40.0-develop.28) (2025-11-20)

### Bug Fixes

* alias support for cooldown ([73e8157](73e8157))

### Features

* cooldown bypass ([#1137](#1137)) ([9ceefef](9ceefef))
@github-actions
Copy link

🎉 This PR is included in version 1.40.0-develop.28 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants