-
-
Notifications
You must be signed in to change notification settings - Fork 78
feat: cooldown bypass for scan on demand #1137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Works great with discord, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request implements cooldown bypass functionality for scanner modes, allowing certain roles to skip cooldown restrictions when using scan-on-demand features. The changes add a new permission system that determines which scanner modes should bypass cooldowns based on user roles and provider type.
Key changes:
- Added
scannerCooldownBypassfunction to determine bypass permissions - Enhanced
mergePermsutility to handle merging of both existing and incoming permission keys - Integrated cooldown bypass logic into scanner configuration and execution
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/utils/scannerPerms.js | Adds new scannerCooldownBypass function to determine bypass permissions |
| server/src/utils/mergePerms.js | Enhances permission merging to handle cases where keys exist in only one object |
| server/src/services/TelegramClient.js | Integrates cooldown bypass permissions for Telegram users |
| server/src/services/LocalClient.js | Adds cooldown bypass support for local authentication |
| server/src/services/DiscordClient.js | Implements cooldown bypass permissions for Discord users |
| server/src/routes/rootRouter.js | Initializes empty cooldown bypass array in settings |
| server/src/graphql/resolvers.js | Implements cooldown bypass logic in scanner configuration and execution |
| config/default.json | Adds cooldown bypass configuration structure |
| config/custom-environment-variables.json | Defines environment variables for cooldown bypass settings |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1a0dd9a to
14d59bf
Compare
|
Everyone else: if you tested and it is working well, please also leave a note so I can know. :) |
|
Wrong week for me to test anything other than my patience (not you haha), so busy this week sorryOn 26 Sep 2025, at 03:15, Mygod ***@***.***> wrote:Mygod left a comment (WatWowMap/ReactMap#1137)
Everyone else: if you tested and it is working well, please also leave a note so I can know. :)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
🎉 This PR is included in version 1.40.0-develop.28 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Fixes #947. I couldn't test this one either so summoning testers. @kamieniarz @nileplumb @prof-miles0 @Shyvadi