feat: tappables #1143
Merged
feat: tappables #1143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for "tappables" as a new feature category, adding comprehensive support for displaying, filtering, and managing tappable items on the map with associated rewards.
- Adds full tappable support including queries, models, UI components, and filtering
- Implements tappable-specific marker rendering with reward display and customizable appearance
- Integrates tappables into existing infrastructure (store, drawer, filters, permissions)
Reviewed Changes
Copilot reviewed 43 out of 46 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/store/useStorage.js | Adds tappables to storage filters and menus configuration |
| src/store/useMemory.js | Adds tappables state management and counters |
| src/services/queries/tappable.js | New GraphQL query for fetching tappable data |
| src/services/queries/index.js | Exports tappable query methods |
| src/services/queries/available.js | Adds available tappables query |
| src/services/Assets.js | Adds tappable icon retrieval method |
| src/pages/map/tileObject.js | Registers tappable tile component |
| src/pages/map/hooks/usePermCheck.js | Adds tappables permission checking |
| src/pages/map/hooks/useGenTappables.js | New hook for generating tappable filters |
| src/pages/map/components/*.jsx | Integrates tappables into map effects and query data |
| src/hooks/*.js | Updates utility hooks to support tappables |
| src/features/tappable/*.js | New tappable feature implementation with tile and popup components |
| src/features/drawer/*.jsx | Adds tappable drawer and integrates into extras |
| src/components/popups/*.jsx | Updates popup components to support flexible grid sizing |
| src/components/filters/FilterMenu.jsx | Refactors filter menu to support any category with menu config |
| src/assets/css/main.css | Adds CSS styles for tappable markers |
| server/src/**/*.js | Backend implementation including models, GraphQL resolvers, and filters |
| config/default.json | Configuration updates for tappable defaults and permissions |
| packages/locales/lib/human/en.json | Adds tappable-related translations |
| package.json | Updates uicons.js dependency to support tappable icons |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
🎉 This PR is included in version 1.40.0-develop.13 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1106. No data to test yet.