fix: update for Golbat #312 #1151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates field names from quest_location_card to quest_background across the codebase to align with Golbat #312. This is a straightforward field rename that maintains consistency between the frontend and backend systems.
Key changes:
- Renamed
quest_location_cardtoquest_backgroundin GraphQL schemas, queries, and backend models - Added German localization entries for new features including quest Pokemon, tappables, routes, and expert filter syntax
- Removed obsolete localization keys
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/services/queries/search.js | Updated GraphQL query field name from quest_location_card to quest_background |
| src/services/queries/pokestop.js | Updated GraphQL query field name from quest_location_card to quest_background |
| server/src/models/Pokestop.js | Updated model field references from quest_location_card to quest_background |
| server/src/graphql/typeDefs/scanner.graphql | Updated GraphQL type definition field name from quest_location_card to quest_background |
| server/src/graphql/typeDefs/map.graphql | Updated GraphQL type definition field name from quest_location_card to quest_background |
| packages/locales/lib/human/de.json | Added extensive German translations for new features and removed obsolete keys |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Mygod
reviewed
Oct 17, 2025
packages/locales/lib/human/de.json
Outdated
| "expert_group_2": "Gruppe 2", | ||
| "expert_group_2_description": "Hohes Level mit perfektem Angriff.", | ||
| "expert_combine_description": "Kombiniere sie mit einem , oder |:", | ||
| "expert_result_description": "Dieser Filter zeigt Pokémon an, wenn sie die Kriterien für Gruppe 1 erfüllen ODER wenn sie alle Kriterien für Gruppe 2 erfüllen." |
|
🎉 This PR is included in version 1.40.0-develop.16 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if this and golbat PR is merged, can PR the frontend part also