Config Migration #312
Merged
Config Migration #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix invasions & scanArea to singular - Make strategies an array for consistency, add name and types to them - No longer load strategies/routes with `fs`, can now load them straight from the config - Adjust tileservers for new format - Some missed s2cell stuff - Move console.js to scripts as well
- Rename all S2Cell References to Scan Cells - Reintroduce Plurals, I don't have time to make them all singular - Fix db migrations - Use __dirname for more consistent results - Fix clustering in default.json - Areas.json just added in memory once instead of multiple - Custom strategies now load from config instead using `fs` everywhere - module.export adjustments for models - adjust constructor for Pokemon filter model - Remove all references to `stats` perm - Adjust how the dbSelector function works - Remove some commented out code - Rename legacyPkmnFilter to enableMapJsFilter - Deprecate AR check - Name queries
- Add some pvp defaults as a backup - Add a backup map tileserver
- Adds nav and tileserver checks if the name changes - Fix excludeFromTutorial and alwaysEnabledPerms to rename s2cells perm
- Update docker file - Update docker-compose example - Fix manual areas
Mygod
pushed a commit
that referenced
this pull request
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config Migration has been merged into
develop. I've been running it on my production maps for 36 hours without any hiccups/need for manual changes Only thing to note is that you may need to merge your tileservers with the ones indefault.jsonif you were using custom ones before in addition to the default ones.Docker Instructions:
https://gist.github.com/TurtIeSocks/5fda9e3325ee1dd10311aec0e880c40e
Non-Docker Command:
Run migration script with
yarn config-migrateConfig Migration Notes:
🔘 Move locales into map
🔘 Move PVP settings into api
🔘 Move nest hemisphere into api
🔘 Split map object into multiple sub-objects for better organizing
🔘 Cluster Zoom Levels and Limits for each category
The following objects became arrays:
🔘 multiDomains
🔘 tileservers
🔘 navigation
🔘 manualAreas
Authentication was merged into one object that share perm arrays
🔘 If you use multiple strategies, you put all roles/groups into the perm arrays
🔘 If you use local, you just put "local" in the arrays
Deprecated Settings:
🔘 arScanColumn - I think all scanners should now support this, doesn't break anything regardless
🔘 enableFeedback - if you have a feedback link in your config, it will be enabled and vice versa
🔘 enableStats - same as above
🔘 noScanAreaOverlay - now detected automatically if you have any manual areas set
Why did I bother with this:
🔘 Now objects and arrays are used in a consistent manner. If there is an object, you shouldn't need to add arbitrary keys or additional fields, what is there, is there. If something is an array, it indicates that you have the ability to add unlimited items to it. Strategies, multiDomains, tileservers, navigation, manualAreas, etc
🔘 Move to node-config library. No longer constrained by the
default.json. If you only want specific tileservers, so be it, you no longer have to edit thedefault.json, keeping the repo git friendly.🔘 Clean up and group the authentication settings