This repository was archived by the owner on Nov 3, 2021. It is now read-only.
Rename memory.drop and table.drop as per agreement #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
added a commit
to alexcrichton/wabt
that referenced
this pull request
Jan 29, 2019
Carrying over renames from WebAssembly/bulk-memory-operations#46
alexcrichton
added a commit
to alexcrichton/wabt
that referenced
this pull request
Jan 29, 2019
Carrying over renames from WebAssembly/bulk-memory-operations#46
alexcrichton
added a commit
to alexcrichton/wabt
that referenced
this pull request
Jan 30, 2019
Carrying over renames from WebAssembly/bulk-memory-operations#46
binji
pushed a commit
to WebAssembly/wabt
that referenced
this pull request
Jan 30, 2019
Carrying over renames from WebAssembly/bulk-memory-operations#46
joyeecheung
pushed a commit
to joyeecheung/v8
that referenced
this pull request
Feb 4, 2019
The new names for memory.drop and table.drop are data.drop and elem.drop respectively. See WebAssembly/bulk-memory-operations#23 and WebAssembly/bulk-memory-operations#46. Change-Id: I07aab8448fabe24eb9734dc7dac6f91c570cb553 Reviewed-on: https://chromium-review.googlesource.com/c/1446148 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#59261}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per ticket #23, memory.drop -> data.drop and table.drop -> elem.drop. This updates only the overview document.