Remove trapping checks on unused lifted bytes #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
approved these changes
Jun 1, 2022
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jun 3, 2022
With WebAssembly/component-model#35 this is no longer a TODO
alexcrichton
added a commit
to bytecodealliance/wasmtime
that referenced
this pull request
Jun 6, 2022
* Rewrite a TODO as a note With WebAssembly/component-model#35 this is no longer a TODO * typo
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jun 7, 2022
This commit updates lifting for integer types and boolean types to account for WebAssembly/component-model#35 where extra bits are now discarded instead of being validated as all zero.
alexcrichton
added a commit
to bytecodealliance/wasmtime
that referenced
this pull request
Jun 7, 2022
This commit updates lifting for integer types and boolean types to account for WebAssembly/component-model#35 where extra bits are now discarded instead of being validated as all zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #34.