Skip to content

Conversation

dschuff
Copy link
Member

@dschuff dschuff commented Oct 2, 2025

Use the unquoted form in the comment, to match the previous output.

Use the unquoted form in the comment, to match the previous output.
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, instead of whacky optional flags, can we just factor out of_loc_unquoted into a separate function?

@dschuff
Copy link
Member Author

dschuff commented Oct 3, 2025

Done.

@dschuff dschuff changed the title [interpreter] JS Conversion: make of_loc optionally quote its output [interpreter] JS Conversion: add of_loc_unquoted and use it in comments Oct 7, 2025
@dschuff dschuff requested a review from rossberg October 8, 2025 22:47
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo previous comments

@dschuff dschuff merged commit e2de519 into WebAssembly:main Oct 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants