Skip to content

[interpreter] JS Conversion: add of_loc_unquoted and use it in comments #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2025
Merged

[interpreter] JS Conversion: add of_loc_unquoted and use it in comments #1997

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
328cfe2
[interpreter] JS Conversion: make of_loc optionally quote its output
dschuff Oct 2, 2025
96a5b42
factor out of_loc_unquoted
dschuff Oct 3, 2025
3d0b247
apply review suggestsions
dschuff Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions interpreter/script/js.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,8 +672,11 @@ let of_bytes = of_string_with String.iter add_hex_char
let of_string = of_string_with String.iter add_char
let of_name = of_string_with List.iter add_unicode_char

let of_loc_unquoted at =
Filename.basename at.left.file ^ ":" ^ string_of_int at.left.line

let of_loc at =
of_string (Filename.basename at.left.file ^ ":" ^ string_of_int at.left.line)
of_string(of_loc_unquoted at)

let of_float z =
match string_of_float z with
Expand Down Expand Up @@ -812,8 +815,8 @@ let of_assertion env ass =
of_assertion' env act loc "assert_exception" [] None

let of_command env cmd =
"\n// " ^ of_loc_unquoted cmd.at ^ "\n" ^
let loc = of_loc cmd.at in
"\n// " ^ loc ^ "\n" ^
match cmd.it with
| Module (x_opt, def) ->
let rec unquote def =
Expand Down