Skip to content

Conversation

dschuff
Copy link
Member

@dschuff dschuff commented Oct 3, 2025

Currently the environment variable is ignored and we always build an ED, which pubrules wont' validate.

@dschuff dschuff changed the title Override W3C_STATUS Makefile variable when building echidna-published… Override W3C_STATUS Makefile var when building specs for Echidna Oct 3, 2025
@dschuff dschuff requested review from rossberg and tlively October 3, 2025 21:48
@dschuff
Copy link
Member Author

dschuff commented Oct 3, 2025

We still have the problem that the core spec makes the echidna validation service fall over somehow, causing an error when trying to retrieve the result. But the other 2 specs upload and validate. In a separate PR I'll do something about that.

Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is intended that the katex submodule is changed?

@dschuff
Copy link
Member Author

dschuff commented Oct 3, 2025

oops no, i just fail at git submodules

Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure what this does, but LGTM :)

@Ms2ger Ms2ger merged commit cb97007 into main Oct 6, 2025
11 of 12 checks passed
@Ms2ger Ms2ger deleted the w3c-status branch October 6, 2025 10:38
@Ms2ger
Copy link
Collaborator

Ms2ger commented Oct 6, 2025

@dschuff looks like it also still has the dry-run option on

@dschuff
Copy link
Member Author

dschuff commented Oct 6, 2025

@dschuff looks like it also still has the dry-run option on

Thanks, #2001

The other option would be to make those variables more directly driven by the environment rather than the Makefile, although I like that they currently have reasonable defaults for local use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants