Skip to content

[Win] editing/selection/caret-rtl-right.html is randomly failing #18933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fujii
Copy link
Contributor

@fujii fujii commented Oct 11, 2023

d68b953

[Win] editing/selection/caret-rtl-right.html is randomly failing
https://bugs.webkit.org/show_bug.cgi?id=262460

Reviewed by Don Olmstead.

The following tests were randomly failing becuase a click sometimes
dispatched a double-click event.

  editing/deleting/smart-delete-001.html
  editing/deleting/smart-delete-003.html
  editing/deleting/smart-delete-004.html
  editing/selection/5057506.html
  editing/selection/caret-ltr-right.html
  editing/selection/caret-rtl-right.html

Reset the mouse position after the previous test not to dispatch a
fake double-click event for a click in the next page.

* LayoutTests/platform/wincairo/TestExpectations:
* LayoutTests/platform/wincairo/editing/deleting/smart-delete-004-expected.txt:
* Tools/WebKitTestRunner/win/TestControllerWin.cpp:

Canonical link: https://commits.webkit.org/269217@main

9959177

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim 🛠 mac-AS-debug 🧪 wpe-wk2
✅ 🧪 webkitperl 🧪 ios-wk2 🧪 api-mac ✅ 🛠 gtk
🧪 ios-wk2-wpt 🧪 mac-wk1 🧪 gtk-wk2
🧪 api-ios 🧪 mac-wk2 ✅ 🧪 api-gtk
🛠 tv 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@fujii fujii requested a review from JonWBedard as a code owner October 11, 2023 08:06
@fujii fujii self-assigned this Oct 11, 2023
@fujii fujii added the HTML Editing For bugs in HTML editing support (including designMode and contentEditable). label Oct 11, 2023
@fujii fujii requested review from rkirsling and donny-dont October 11, 2023 08:08
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 11, 2023
@fujii fujii removed the merging-blocked Applied to prevent a change from being merged label Oct 11, 2023
@fujii fujii force-pushed the eng/Win-editingselectioncaret-rtl-right-html-is-randomly-failing branch from 0f04d96 to 9959177 Compare October 11, 2023 20:18
@fujii fujii added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 11, 2023
https://bugs.webkit.org/show_bug.cgi?id=262460

Reviewed by Don Olmstead.

The following tests were randomly failing becuase a click sometimes
dispatched a double-click event.

  editing/deleting/smart-delete-001.html
  editing/deleting/smart-delete-003.html
  editing/deleting/smart-delete-004.html
  editing/selection/5057506.html
  editing/selection/caret-ltr-right.html
  editing/selection/caret-rtl-right.html

Reset the mouse position after the previous test not to dispatch a
fake double-click event for a click in the next page.

* LayoutTests/platform/wincairo/TestExpectations:
* LayoutTests/platform/wincairo/editing/deleting/smart-delete-004-expected.txt:
* Tools/WebKitTestRunner/win/TestControllerWin.cpp:

Canonical link: https://commits.webkit.org/269217@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Win-editingselectioncaret-rtl-right-html-is-randomly-failing branch from 9959177 to d68b953 Compare October 11, 2023 20:33
@webkit-commit-queue
Copy link
Collaborator

Committed 269217@main (d68b953): https://commits.webkit.org/269217@main

Reviewed commits have been landed. Closing PR #18933 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d68b953 into WebKit:main Oct 11, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 11, 2023
@fujii fujii deleted the eng/Win-editingselectioncaret-rtl-right-html-is-randomly-failing branch October 11, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HTML Editing For bugs in HTML editing support (including designMode and contentEditable).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants