Skip to content

[WPE] WPE Platform: add a method to create a new WPEDisplayHeadless using a custom device file #34519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2024
Merged

[WPE] WPE Platform: add a method to create a new WPEDisplayHeadless using a custom device file #34519

merged 1 commit into from
Oct 7, 2024

Conversation

siwei-li
Copy link
Contributor

@siwei-li siwei-li commented Oct 1, 2024 •
edited by webkit-early-warning-system
Loading

a836ac5

[WPE] WPE Platform: add a method to create a new WPEDisplayHeadless using a custom device file
https://bugs.webkit.org/show_bug.cgi?id=280701

Reviewed by Carlos Garcia Campos.

Add a `wpe_display_headless_new_for_device()` method to the headless
backend in order to create a new display from the specified DRM device.

* Source/WebKit/WPEPlatform/wpe/headless/WPEDisplayHeadless.cpp:
(wpe_display_headless_new_for_device):
* Source/WebKit/WPEPlatform/wpe/headless/WPEDisplayHeadless.h:

Canonical link: https://commits.webkit.org/284755@main

054b75d

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@siwei-li siwei-li requested review from a team and zdobersek as code owners October 1, 2024 19:57
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 1, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 7f563e1)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
  🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 2, 2024
@Ahmad-S792 Ahmad-S792 added the WPE WebKit WebKit WPE component label Oct 2, 2024
carlosgcampos
carlosgcampos reviewed Oct 2, 2024
View reviewed changes
Source/WebKit/WPEPlatform/wpe/headless/WPEDisplayHeadless.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it's not device found

Source/WebKit/WPEPlatform/wpe/headless/WPEDisplayHeadless.cpp Outdated
Comment on lines +263 to +264
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here it's device not found and return

Source/WebKit/WPEPlatform/wpe/headless/WPEDisplayHeadless.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably be and #else then

@siwei-li siwei-li force-pushed the eng/WPE-WPE-Platform-add-a-method-to-create-a-new-WPEDisplayHeadless-using-a-custom-device-file branch from 7f563e1 to f54be68 Compare October 3, 2024 03:33
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 3, 2024 •
edited
Loading

EWS run on previous version of this PR (hash f54be68)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt ❌ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
loading 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ⏳ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@siwei-li siwei-li force-pushed the eng/WPE-WPE-Platform-add-a-method-to-create-a-new-WPEDisplayHeadless-using-a-custom-device-file branch from f54be68 to 054b75d Compare October 7, 2024 06:50
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 7, 2024 •
edited
Loading

EWS run on current version of this PR (hash 054b75d)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@carlosgcampos carlosgcampos added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Oct 7, 2024
@siwei-li @carlosgcampos
[WPE] WPE Platform: add a method to create a new WPEDisplayHeadless u…
a836ac5 
…sing a custom device file

https://bugs.webkit.org/show_bug.cgi?id=280701

Reviewed by Carlos Garcia Campos.

Add a `wpe_display_headless_new_for_device()` method to the headless
backend in order to create a new display from the specified DRM device.

* Source/WebKit/WPEPlatform/wpe/headless/WPEDisplayHeadless.cpp:
(wpe_display_headless_new_for_device):
* Source/WebKit/WPEPlatform/wpe/headless/WPEDisplayHeadless.h:

Canonical link: https://commits.webkit.org/284755@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WPE-WPE-Platform-add-a-method-to-create-a-new-WPEDisplayHeadless-using-a-custom-device-file branch from 054b75d to a836ac5 Compare October 7, 2024 09:00
@webkit-commit-queue
Copy link
Collaborator

Committed 284755@main (a836ac5): https://commits.webkit.org/284755@main

Reviewed commits have been landed. Closing PR #34519 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit a836ac5 into WebKit:main Oct 7, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosgcampos carlosgcampos carlosgcampos approved these changes

@zdobersek zdobersek Awaiting requested review from zdobersek

Assignees

@siwei-li siwei-li

Labels

WPE WebKit WebKit WPE component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@siwei-li @webkit-early-warning-system @webkit-commit-queue @carlosgcampos @Ahmad-S792 @webkit-ews-buildbot