-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accessibility features with alt images and comment in user.html #1972
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1972 +/- ##
==========================================
- Coverage 82.78% 82.35% -0.44%
==========================================
Files 26 25 -1
Lines 2759 2771 +12
Branches 411 411
==========================================
- Hits 2284 2282 -2
- Misses 381 389 +8
- Partials 94 100 +6 |
<a class="button inline" href="{% url "support" %}">{% trans "Get support" %}</a> | ||
<!-- Button to get support with translation support --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't find these comments useful. Comments are for things which you can not easily see from the code, but this more looks like a comment generated from the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files are not desired in the repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feedback. Just for some context, are the files that include the alt image not helpful also? If I remove the comments from the user.html and leave the rest, would that be ok?
This pull request has been automatically marked as stale because there wasn’t any recent activity. It will be closed soon if no further action occurs. Thank you for your contributions! |
Proposed changes
Checklist
Other information