accessibility features with alt images and comment in user.html #1972
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1972 +/- ##
==========================================
+ Coverage 82.28% 82.35% +0.07%
==========================================
Files 25 25
Lines 2771 2771
Branches 411 411
==========================================
+ Hits 2280 2282 +2
+ Misses 390 389 -1
+ Partials 101 100 -1 |
| <a class="button inline" href="{% url "support" %}">{% trans "Get support" %}</a> | ||
| <!-- Button to get support with translation support --> |
There was a problem hiding this comment.
I really don't find these comments useful. Comments are for things which you can not easily see from the code, but this more looks like a comment generated from the code.
There was a problem hiding this comment.
These files are not desired in the repository.
There was a problem hiding this comment.
Thank you for the feedback. Just for some context, are the files that include the alt image not helpful also? If I remove the comments from the user.html and leave the rest, would that be ok?
There was a problem hiding this comment.
Having useful alt for content images is definitely helpful. For some, it might be just better to not pollute screen reader with them (for example icons on the features pages). Read https://support.google.com/webmasters/thread/231898341/is-alt-on-image-a-must-have?hl=en to see where alt is not actually desired.
|
This pull request has been automatically marked as stale because there wasn’t any recent activity. It will be closed soon if no further action occurs. Thank you for your contributions! |
github-actions
bot
added
wontfix
|
This pull request has been automatically marked as stale because there wasn’t any recent activity. It will be closed soon if no further action occurs. Thank you for your contributions! |
Proposed changes
Checklist
Other information