Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accessibility features with alt images and comment in user.html #1972

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

qtop1
Copy link

@qtop1 qtop1 commented May 13, 2024

Proposed changes

Checklist

  • [x ] Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • [x ] I have described the changes in the commit messages.

Other information

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.35%. Comparing base (5ed0761) to head (2a5220b).
Report is 357 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1972      +/-   ##
==========================================
- Coverage   82.78%   82.35%   -0.44%     
==========================================
  Files          26       25       -1     
  Lines        2759     2771      +12     
  Branches      411      411              
==========================================
- Hits         2284     2282       -2     
- Misses        381      389       +8     
- Partials       94      100       +6     

<a class="button inline" href="{% url "support" %}">{% trans "Get support" %}</a>
<!-- Button to get support with translation support -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't find these comments useful. Comments are for things which you can not easily see from the code, but this more looks like a comment generated from the code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files are not desired in the repository.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback. Just for some context, are the files that include the alt image not helpful also? If I remove the comments from the user.html and leave the rest, would that be ok?

Copy link

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

@github-actions github-actions bot added wontfix Nobody will work on this. and removed wontfix Nobody will work on this. labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants