Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accessibility features with alt images and comment in user.html #1972

Closed
wants to merge 2 commits into from
Closed

accessibility features with alt images and comment in user.html #1972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f66674
accessibility features with alt images and comment in user.html
May 13, 2024
2a5220b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
View file
Open in desktop
Binary file not shown.
Binary file added .github/.DS_Store
View file
Open in desktop
Binary file not shown.
Binary file added locale/.DS_Store
View file
Open in desktop
Binary file not shown.
Binary file added payments/.DS_Store
View file
Open in desktop
Binary file not shown.
Binary file added weblate_web/.DS_Store
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files are not desired in the repository.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback. Just for some context, are the files that include the alt image not helpful also? If I remove the comments from the user.html and leave the rest, would that be ok?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having useful alt for content images is definitely helpful. For some, it might be just better to not pollute screen reader with them (for example icons on the features pages). Read https://support.google.com/webmasters/thread/231898341/is-alt-on-image-a-must-have?hl=en to see where alt is not actually desired.

Binary file not shown.
2 changes: 1 addition & 1 deletion weblate_web/templates/about.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ <h2 class="section-title crypto">{% trans "The Weblate history" %}</h2>
<section class="donations-info aboutus">
<div class="di-section">
<div class="half half-img rotate">
<img src="{% static "img/michal-cihar.jpg" %}" />
<img src="{% static "img/michal-cihar.jpg" %}" alt="Image of michal-cihar" />
</div>
<div class="half half-content">
<h2>Michal Čihař</h2>
Expand Down
6 changes: 3 additions & 3 deletions weblate_web/templates/discover.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ <h1 class="section-title min-m">{% block title %}{% trans "Discover Weblate" %}{
<img class="discover-img" src="{{ service.discover_image.url }}" />
{% else %}
<div class="discover-panel layered">
<img src="{% static "img/discover-bg.png" %}" />
<img src="{% static "img/discover-bg.png" %}" alt="Background Image"/>
<div class="discover-name">
<img src="{% static "img/discover-weblate-logo.png" %}" class="discover-logo" />
<img src="{% static "img/discover-weblate-logo.png" %}" class="discover-logo" alt="Weblate logo"/>
<span>{{ service.site_title }}</span>
</div>
</div>
Expand Down Expand Up @@ -66,7 +66,7 @@ <h2><a href="{{ service.site_url }}" target="_blank" rel="ugc" lang="en" dir="lt
<a class="project" href="{{ service.site_url }}{{ project.url }}" target="_blank" rel="ugc">{{ project.name }}</a>
{% endfor %}
{% if service.non_matched_projects_count %}
<a href="{{ service.site_url }}/projects/" target="_blank" rel="ugc"><img src="{% static "img/three-dots.svg" %}" title="{% blocktrans count count=service.non_matched_projects_count %}…and {{ count }} more{% plural %}…and {{ count }} more{% endblocktrans %}" /></a>
<a href="{{ service.site_url }}/projects/" target="_blank" rel="ugc"><img src="{% static "img/three-dots.svg" %}" alt="Three dots icon " title="{% blocktrans count count=service.non_matched_projects_count %}…and {{ count }} more{% plural %}…and {{ count }} more{% endblocktrans %}" /></a>
{% endif %}
{% if service.pk in user_services %}
<a class="button small float-right" href="{% url "service-discovery" pk=service.pk %}">{% trans "Customize listing" %}</a>
Expand Down
12 changes: 6 additions & 6 deletions weblate_web/templates/donate.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ <h2 class="section-title">{% trans "Recurring donations and rewards" %}</h2>
<section class="donations-info">
<div class="di-section">
<div class="half half-img rotate">
<img src="{% static "img/LeftPhoto.jpg" %}" />
<img src="{% static "img/LeftPhoto.jpg" %}" alt="Crowd raising arms with Weblate logo above"/>
</div>
<div class="half half-content">
<h2>{% trans "Weblate heroism" %}</h2>
Expand All @@ -65,7 +65,7 @@ <h2>{% trans "Weblate heroism" %}</h2>
</div>
<div class="di-section">
<div class="half half-img rotate">
<img src="{% static "img/RightPhoto.jpg" %}" />
<img src="{% static "img/RightPhoto.jpg" %}" alt="Someone doing salutation with Weblate logo above" />
</div>
<div class="half half-content">
<h2>{% trans "Single appreciative donation" %}</h2>
Expand All @@ -75,7 +75,7 @@ <h2>{% trans "Single appreciative donation" %}</h2>
</div>
<div class="di-section" id="swag">
<div class="half half-img border">
<img src="{% static "img/swag.jpg" %}" />
<img src="{% static "img/swag.jpg" %}" alt="Weblate merchandise" />
</div>
<div class="half half-content">
<h2>{% trans "Weblate swag" %}</h2>
Expand All @@ -95,15 +95,15 @@ <h2 class="section-title crypto">{% trans "Your favorite donation platforms" %}<
</div>
<div class="donate-platforms">
<a href="https://github.com/sponsors/WeblateOrg">
<img src="{% static "img/donate-github.svg" %}" />
<img src="{% static "img/donate-github.svg" %}" alt="GitHub Cat logo"/>
{% trans "GitHub Sponsors" %}
</a>
<a href="https://liberapay.com/Weblate/">
<img src="{% static "img/donate-liberapay.svg" %}" />
<img src="{% static "img/donate-liberapay.svg" %}" alt="Liberapay Logo" />
Liberapay
</a>
<a href="https://opencollective.com/weblate">
<img src="{% static "img/donate-opencollective.svg" %}" />
<img src="{% static "img/donate-opencollective.svg" %}" alt="Opencollective Logo"/>
Open Collective
</a>
</div>
Expand Down
Loading