Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing bytes will be saved to the file instantly? #841

Closed
1 task
CaptainCoward opened this issue Dec 4, 2022 · 2 comments
Closed
1 task

Removing bytes will be saved to the file instantly? #841

CaptainCoward opened this issue Dec 4, 2022 · 2 comments
Labels
bug Something isn't working feature request

Comments

@CaptainCoward
Copy link

CaptainCoward commented Dec 4, 2022

Operating System

Windows

What's the issue you encountered?

I'm note sure if this is a bug, though it wasn't obvious to me that when you right click on some selected hex code > remove > set
the bytes will be removed from the file instantly it then doesn't matter if you close the provider and discard your changes, since the changes (removed bytes) are already done.
Is this really how it supposed to be?

How can the issue be reproduced?

Just open any file, select some bytes, right click > remove > set.

ImHex Version

1.25.0

ImHex Build Type

  • Nightly or built from sources

Installation type

Windows Portable

Additional context?

No response

@CaptainCoward CaptainCoward added the bug Something isn't working label Dec 4, 2022
@Nemoumbra
Copy link
Contributor

This is indeed the intended way of handling files and not a bug. It's a bit hard to explain, but the way ImHex works implies certain limitations on what can and can't be done.
I am not trying to say this is how it will stay for eternity, but changing this requires writing a lot of new code and coordinating things with WerWolv. There is just not enough enthusiasts to implement other modes for file processing.

I propose replacing the "bug" label with the "feature request".

@RetroEdit
Copy link

RetroEdit commented Mar 10, 2024

The other issue (#1548) is closed presumably as a duplicate, which is fair enough, but I will note for future context that the overall issue is most operations apply instantly and save to the file without any explicit indication, not just this particular operation.

I do sympathize with this hex editor being coded with a particular workflow in mind, but this also makes it undesirable and dangerous for my typical use cases, which is fine; I'll just use another tool or maybe submit a PR at some point if I get particularly motivated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature request
Projects
None yet
Development

No branches or pull requests

4 participants