Fixes for layout of large font labels in IEEE 745 floating point tool #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # plugins/builtin/source/content/tools_entries.cpp
…ptured by lambda instead.
Better support for large sized font layout of bit labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
The issue seems to only affect the web version of ImHex but it is not clear why. The labels of the checkboxes that represent bits in the IEEE 745 floating point tool were lay out incorrectly.
Implementation description
The new code ensures that the bit labels are centered and located in the middle of the checkbox regardless of the font size and the dear imgui sized checkboxes.