add iconName to Dropdown #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsutterfield Since the <Dropdown toggle="Toggle dropdown" icon=IconDropdownTiny >
<p style={{padding: '12px'}}>I am a text inside dropdown!</p>
</Dropdown> |
|
Sorry for not catching that earlier - the icon should already be replaced in Wikia/react-design-system#89 ages ago |
|
@vforge I ran into the following error when trying to pass the icon-specific component as a parameter:
I opted to take the same approach that BannerNotification does. Namely, using strings as the arguments and proptypes but using the value of the string to figure out which icon component to render. |
xkxd
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Dropdown component to take an optional
iconNamewhich is used to determine the chevron for the dropdown.We're using this Dropdown for the category picker in Feeds. The designs call for a different chevron for desktop vs mobile. See:
https://app.zeplin.io/project/5b563d14e825ad811a6d3226/screen/5c6260e5ad81ec99d9f194b1
https://app.zeplin.io/project/5b563d14e825ad811a6d3226/screen/5c6260e9959ef19a21f6ae39
/cc @Wikia/iwing @vforge
Relates to https://github.com/Wikia/fepo/pull/439