Skip to content
This repository was archived by the owner on Jan 21, 2019. It is now read-only.

Conversation

vforge
Copy link
Collaborator

@vforge vforge commented Dec 26, 2018

  • Added an extractor that extracts assets from the DS and converting them to components
  • Added Icons and Assets
  • Updated components to use new icons

@vforge vforge added the WIP label Dec 26, 2018
@coveralls
Copy link

coveralls commented Dec 26, 2018

Pull Request Test Coverage Report for Build 596

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 586: 0.0%
Covered Lines: 428
Relevant Lines: 428

💛 - Coveralls

@vforge vforge removed the WIP label Jan 13, 2019
@vforge vforge requested a review from JoshuaRogan January 14, 2019 05:34
Copy link
Contributor

@JoshuaRogan JoshuaRogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out locally LGTM

@JoshuaRogan
Copy link
Contributor

Typo "controls"

This is system that controlls the state of site notifications, allows to add them via actions, and outputs them to a component.

@JoshuaRogan
Copy link
Contributor

Fandom creator decided to modify how we create our records. We had a pattern of creating a default record that we could export but Geoff dug into a bit and saw the recommended way was to export an instance of a model https://github.com/Wikia/fandom-creator/blob/077da02d0d84ea7532609589c6bce4e6df1c725c/react-client/src/models/NavInfo.js#L41

See: https://github.com/Wikia/fandom-creator/pull/1364
Type Validator: https://github.com/Wikia/fandom-creator/blob/426290a6f6f810f5721fe06865c9e6f623695e03/react-client/src/util/isRecordOfType.js#L1

@vforge
Copy link
Collaborator Author

vforge commented Jan 14, 2019

@JoshuaRogan Interesting point about Records - I'll look into it.

@vforge vforge merged commit b89c557 into master Jan 14, 2019
@vforge vforge deleted the svg-assets branch January 14, 2019 19:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants