Repository navigation
Actions Monitor v2026.09.11
2026-07-15
-
Workflow form: no more dead space when resized taller — extra vertical space used to be distributed as odd empty gaps between the fixed-height fields (the form layout had no stretch sink). The config.yaml preview now takes stretch factor 1 (min height 150), so resizing the dialog grows the preview and everything else stays snug.
-
Settings: Edit crashed for quoted PR/URL entries — clicking Edit on a workflow whose config values were quoted (
mode: "pr",mode: "url") raisedyaml.representer.RepresenterError: cannot represent an objectfrom the form's YAML preview: ruamel's round-trip loader (preserve_quotes=True) returnsScalarStringsubclasses thatyaml.safe_dumprefuses, and the form re-inserted them into the rebuilt entry. Newto_plain()recursively converts ruamel container/scalar types to plain Python; applied when an entry entersWorkflowFormDialogand defensively insideentry_to_yaml(). Regression test covers editing ruamel-loadedprandurlentries. -
Sort menu polish (user feedback) — the ▲/▼ glyphs in the sort dropdown and active sort label carry U+FE0E (text presentation selector) so Windows renders them monochrome instead of hijacking them with the colour-emoji font, and the menu now pops up anchored under the section's Sort label (right-aligned) instead of floating at the cursor, which could land it detached beyond the window edge.
-
Settings polish (user feedback) — notification-type rows gained "Sound" / "Enabled" column headers (plus tooltips on the dropdown/checkbox) so it's clear what each control does; labels inside cards no longer render dark background boxes (
QLabel { background: transparent }reset at dialog level, same root cause as the row-card patches); long labels (staleness note, token how-to steps, notification subtitles, empty-list hint) now word-wrap instead of forcing pages wider than the dialog; the add/edit-workflow dialog opens tall enough (up to 940px, clamped to screen height) that all fields plus Cancel / Add workflow are visible without scrolling. -
Row cards paint uniformly — the app-wide
QWidget { background-color }stylesheet rule paintedBG_DARKpatches behind the row's child container widgets (badge row, right column, name/branch spacer) on top of the v2 card fill, making row backgrounds look blotchy.WorkflowRowstylesheets now appendWorkflowRow QWidget { background-color: transparent }so the card fill (and hover/snooze/blink variants) shows through everywhere; widget-level styles (accent bar, badges, snooze hover) still win. Blink-on-focus goes through a newpaint_bg()helper so mid-blink frames keep the transparency reset too. -
ACTIONS_MONITOR_BETAenv override +task run:beta— beta flags can be force-enabled per process via a comma-separated env var (e.g.ACTIONS_MONITOR_BETA=settings_ui) without editing config.yaml;task run:betawraps it for source runs. The override copies the mergedbetadict before mutating —_deep_mergeshallow-copies only one level, so writing through the shared reference would have poisonedDEFAULT_CONFIGfor every later reload (caught by the test suite). -
Integration test suite + screenshot harness — new
tests/(33 tests) driving the real Qt UI offscreen with no network: poller threads are kept dormant and poll results injected asStatusEvents (app_envfixture with per-test temp config/state). Covers empty state, row creation/removal, summary-strip counts, section counts, snooze (incl. summary exclusion), sort menu persistence, red failure info lines, error rows, beta-flag gating (incl. hot-reload), settings pages writing config.yaml (comment preservation, invalid-duration/regex/YAML rejection), workflow form mode detection + entry building.test_screenshot_*tests save PNGs of the main window and every settings page toartifacts/screenshots/(gitignored). NewTaskfile.yml(task install-dev / test / screenshots / run / build). Screenshot pass caught and fixed two real layout bugs: the settings content pane rendered on the default light palette without the app stylesheet (tests now apply it for parity), and non-wrapping field labels forced the add-workflow form wider than its dialog (labels now word-wrap; form min width 660). -
In-app Settings window (beta) — new
src/settings_ui.pyimplementing the Settings Window design: left-nav dialog with five pages. Workflows: list of configured entries (name, mode badge, summary, polling rate) with Add/Edit/Remove; the add/edit form auto-detects the mode from a pasted GitHub URL (workflow file → branch/PR,?query=actor:→ actor, search/pulls URL → Search URL with query extraction), shows per-mode option cards (branch filter; PR max rows / stale-after / extra + ignore workflows; actor failed-filter; search query) and a live YAML preview of the entry. Notifications: per-type enable + sound, delivery (batch window / suppress-older-than / toast duration), PR-mode overrides with tri-state inherit. PR rules: staleness thresholds, Jira base URL, bot-reviewer regex with presets. GitHub account: token field + async "Test token" (login + rate-limit remaining). Raw YAML: in-dialog editor with YAML validation on save. Writes go to config.yaml immediately via ruamel.yaml round-trip (user comments preserved; PyYAML fallback) — newruamel.yamldependency — and reach the pollers through the existing hot-reload watcher. Opened from the beta-gated header gear / footer "⚙ Settings" link; with the flag off those entry points fall back to opening config.yaml in an editor. -
Main window refreshed to design v2 (
design/actions-monitor-improvement-designs/) — rows are now uniform rounded cards (#262220, 6px radius, 3px gap, hover#2C2825) with an inset pill accent bar, replacing zebra striping; snoozed rows dim to#221F1D. New summary strip under the header shows a worst-status dot,N failed · N running · N passingcounts, and anUpdated HH:MMtimestamp. Header is 52px with 30×30 hover-rounded icon buttons (18px glyphs) and a 30px logo. Section headers gained a row count and an inlineSort ▾dropdown menu (replaces the per-section sort bar; same six modes + clear,state.jsonpersistence unchanged). Footer collapsed to a single row (#232020): toggles left, config/settings link right. First-run empty state with an "Add a workflow" call-to-action. Failed/errored rows render their status line in red. Badges bumped to 10px/2×6px padding, titles to 13px#F5F5F4, status icons to 22px. New_make_settings_icon()gear inicons.py. -
beta.settings_uifeature flag — newbeta:config block (all switches off by default, documented inconfig.template.yaml). Whensettings_ui: true, the header shows a gear button (after a divider) and the footer link becomes "⚙ Settings", both opening the upcoming in-app Settings window; when off, the footer keeps the "Open config ↗" editor link and the gear stays hidden. Gating is re-applied on config hot-reload via_apply_beta_flags(). -
"Start with Windows" self-heals stale registry entries — the HKCU Run entry survives repo moves and source→exe migrations pointing at a command that no longer exists (observed: an old
pythonw.exe C:\Repos\...\main.pysource path), so startup silently launched nothing while the checkbox still showed enabled. Frozen builds now callStartupManager.heal()at launch: if an entry exists and differs from the current"{sys.executable}"command, it is rewritten. Source runs never touch the entry (so dev runs don't hijack an exe install's startup). -
PR rows no longer show grey "Unknown" for real build states (#16) — three fixes. (1)
_worst_status()now ranks all seven statuses (failure > running > queued > cancelled > success > skipped > unknown) via_STATUS_PRIORITYinstead of falling through toST_UNKNOWNwhen a PR's runs are all cancelled/skipped — a branch whose only in-window run was a skipped E2E sibling used to render a grey question mark. (2) Per-branch fill-in:PRWorkflowPoller._poll()now fetches the latest run of every configured workflow the bulk actor-filtered fetch didn't surface for an open-PR branch (runs by other actors, or older than the recent window) instead of only branches with zero runs — cheap viaper_page=1+ the 30s TTL / ETag cache layers. (3) Head-SHA fallback: a PR with no runs from any configured workflow at all (e.g. anacceptance → productionPR whose CI lives in production workflows) now falls back to the latest run on its head SHA (fetch_runs_by_sha, mirroring URL mode) so the row reports the PR's real CI status;_cache_pradditionally storeshead_sha. Also addedstartup_failure(→ failure) andstale(→ cancelled) toCONCLUSION_MAP, andwaiting/pending/requestedAPI statuses now resolve to queued instead of unknown. -
Section sorts are now independent per section (#17) —
_cycle_sort()used to clear every other section's sort and re-order those sections back to default whenever any sort label was clicked. Each section now keeps its own Status/Updated/Created sort;state.jsonpersistence already supported multiple entries and is unchanged. -
Full code review sweep — 20+ fixes across all modules. Highlights:
- pollers/gh_api:
_fetch_user_open_prsdropped the nonexistentcreator=param (the Pulls list API ignores it) and now fetches 100 most-recently-updated open PRs with client-side author filtering — previously a busy repo could push the user's PRs out of the 50-item window, silently removing their rows.fetch_actor_runsconclusion filter now uses the runs API'sstatus=param (aconclusion=param is ignored), so actor modefilter: "failed"actually filters server-side. A run that starts and finishes between two polls now fires itssuccess/failureoutcome instead of a misleading "started" toast that permanently swallowed the completion notification (both branch/actor_detect_notificationand the PR-mode aggregate chain). PR-mode notification age-gating now uses the triggering run's own timestamp instead of the representative run's (an old failed sibling no longer suppresses fresh toasts). Manual Refresh clicks landing mid-poll are no longer swallowed (_poll_nowcleared before, not after,_poll()). GraphQLRATE_LIMITEDresponses (HTTP 200 + errors) now trip the shared cooldown gate like REST 429s. - main: config hot-reload swaps in a fresh event queue and drops stale-wid events, so late events from stopped pollers can't create invisible ghost rows that poison the tray icon forever. Branch-mode snoozes now survive restarts and config reloads (registry restored before poller threads start; placeholder-state
run_idtransition no longer force-unsnoozes; reload re-applies the snooze icon)._workflow_stable_keynow includesbranch/filter/nameso two entries sharing a URL don't swap snoozes (note: previously persisted snoozes are invalidated once by the key format change). Duplicate section titles are auto-suffixed ((2)) instead of corrupting section bookkeeping. The startup/manual update check runs on a worker thread (was a blocking 15srequests.geton the Qt main thread). Blink-on-focus survives the row being deleted mid-blink. Zebra striping is computed per section and restriped in visual (sorted) order. - widgets:
WorkflowRownow setsWA_StyledBackground— Qt never auto-enables it for QWidget subclasses, so zebra striping and the toast-click row blink were invisible no-ops. All user-controlled text labels (PR title, name, branch, target, info) areQt.PlainText— a PR title containing<table>-ish markup was parsed as rich text (third-party titles in URL-mode inboxes). Unsnoozing refreshes the status icon pixmap so it can't contradict the accent bar. The PR target label now renders→ targetand links to the target branch tree via newWorkflowState.target_url(it displayed a bare branch word whose click opened the head branch). - update/notifications: helper batch script written as UTF-8 with
chcp 65001(wasencoding="ascii"— updates crashed for non-ASCII install paths); swap helper's wait/kill now filters by image name (Windows) //proc/<pid>/comm(Linux) so PID reuse can't kill an innocent process;_cleanup_stale_mei_dirsrename-guards before rmtree so another long-running PyInstaller app's live_MEIdir is skipped; scoop detection recognises customSCOOP=roots and theapps\<name>\currentlayout; failed downloads re-enable the Update button for retry;_focus.vbswritten as UTF-16 (WSH parses non-BOM files as ANSI → mojibake signal paths); Linux default-sound search skips.ogacandidates when onlyaplay(no Ogg support) is available. - Filed as backlog: sub_key parsing for branch names containing
#(#18) — needs a persisted-format migration.
- pollers/gh_api:
-
Daily Build retries on transient runner starvation — today's scheduled run (
25906763857) failed because therelease / checkjob sat inqueuedfor ~23 minutes without ever being assigned anubuntu-latestrunner; GitHub eventually gave up, dependents were skipped, and the run was markedfailure.build.ymlnow schedules two follow-up crons at 06:00 and 07:00 UTC (in addition to the original 05:00). The_release.ymlcheckjob is already idempotent — once HEAD equals the latest release'starget_commitish,should_build=falseshort-circuits the build/release/scoop jobs — so a successful first run turns subsequent retries into ~10-second no-ops. No retry-state file or external coordination needed.