Feature/local file asset loading #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return NSStringMake(full_path); | ||
| NSString *EJApp::pathForResource(NSString *resourcePath) { | ||
| string full_path = string(EJECTA_APP_FOLDER) + resourcePath->getCString(); | ||
| return NSStringMake(full_path); |
There was a problem hiding this comment.
Yup if I modified an entire method I changed all the syntax in the method (spaces, pointers, whitespace etc.)
There was a problem hiding this comment.
So we should go for spaces instead of tabs?
There was a problem hiding this comment.
Tabs or space is fine as long as a tab is not set to 8 columns! I'm going to indent bomb the whole project later after we get the restructuring done. Not concerned about indentations at the moment.
aogilvie
added a commit
that referenced
this pull request
Mar 25, 2014
Feature/local file asset loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.