Button Block: Update to use color support utils to retrieve classes and styles #30870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
7 tasks
|
Size Change: -307 B (0%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
|
It looks like mobile still uses the @geriux we're introducing a new utility for retrieving classes and inline styles at #30869 Could any of you at mobile check that utility and remove |
oandregal
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
I've noticed that there was a test failure due to removing packages/block-library/src/button/color-props.js that mobile still uses it so I reverted the removal of that file.
Other than that this is ready. Let's wait for tests to pass to merge this, in case I missed something.
Thanks, I saw that this morning. My mistake, I missed updating the native edit component. I've just pushed a commit that updates the button edit component for mobile. As it is a class component the hook utility couldn't be used cleanly in place of the original function from In addition, the native button edit component was still relying on the withColors hook and therefore attributes that wouldn't match those provided by the colors support the button block opts into via the block.json. I believe the last commit brings the native component up-to-date in that respect. With all the above changes, I deleted the
|
jd-alexander
added
the
Mobile App - i.e. Android or iOS
|
Hi @aaronrobertshaw I added the |
Thanks @jd-alexander, I'll keep that label in mind in future. |
Hey @aaronrobertshaw 👋 I'll run some sanity checks, thanks for updating the native files 🎉 |
|
Did some sanity checks and everything looks good on mobile 👍
Thanks! |
The existing color-props.js code has been reworked into a utility exported from the block support hooks to facilitate its reuse across blocks.
This brings the native button component up-to-date after the switch to use the colors block support feature. It now also uses the color utilities for determining color styles and allows for the color-props.js file to be deleted.
aaronrobertshaw
force-pushed
the
update/button-to-use-color-support-utils
branch
from
65c8975
to
b521bb0
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the button block to use a new utility exported from the block support hooks to retrieve color related CSS classes and inline styles which are then applied to inner elements.
The original
color-props.jsfunction has been re-worked into the new utilities mentioned above.How has this been tested?
Manually and via
npm run test-unitto ensure fixture tests still show the correct classes and styles being applied.Test Instructions
npm run test-unitand confirm no failures.Types of changes
Refactor. No new features, no breaking changes.
Checklist:
*.native.jsfiles for terms that need renaming or removal).