-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose initial templates as variations #26194
Comments
This sounds very much like a Placeholder screen for blocks, especially when considering the Columns block. I went with that idea to iterate on some designs for this. Option 1 - SVGsUsing SVGs, we can graphically convey the layout using lines similar to a wireframe. Option 2 - Single layout patternI tried out the preview dimensions from some of the other blocks (ie. 120px X 84px). The space provides just enough room to show a preview of some mock-content or actual post content displayed as a single representational pattern. Option 3 - Multi item patternI expanded the area to show multiple feed items bringing more context to the preview. FeedbackBefore jumping into the next step, I wanted to get some design feedback on these to see if this is the desired direction.
|
Really like those explorations!
Therefore, I think it's good to consider the second one as it seems to be automatically created from theme styles etc. and feels better extendable e. g. for third-party devs. |
Hey @mapk - thanks for exploring this. My first thoughts for now are that it should be consistent with the other core blocks like I'd like to have some thoughts about whether in a placeholder like this, we should include the option to have a fully I haven't made code explorations yet, but it feels like we will need that, so as not to exclude the option for a user to have for example in an |
@ntsekouras I think we should have a separate issue to explore things there. From the top of my mind I can think of:
@mapk in text we should probably refer to these as "post layouts" or "template", variations is more of its technical term. |
@mapk one thing to get out of the way first is to determine if it's better to do these as placeholder variations or patterns, or some sort of mix of both. The placeholder state could also show patterns instead of variations by default (something being discussed a lot for template parts). Alternatively, "patterns" could be a prominent extra button in the placeholder state to toggle between variations and proper patterns. To be clear, I lean a bit more on placeholder variations for the block itself (what you mocked up above) and patterns as a slightly separate flow (on the inserter) for post layouts, but it's worth considering as part of the exploring. |
All really good feedback! Thanks! Decision needed Separation of actions (but all are block variations)
This allows the user to select any of the layout variations to apply to a specific query variation. I'm struggling with terminology here, so please forgive me. Applying different layouts |
Hey @mapk!
I think for our first iteration going with SVGs and following the One thing I have to point out is that for now we will not have Query block variations that include styling or grid like stuff (your example with This issue can focus just on insertion of these:
Although So to sum up
As Matías commented here, this can be a second step and after the first iteration, I'll create another issue for this. |
I see that #26378 is in really good shape and it mirrors mostly how the Columns block work as of today. I think it's a good direction that allows us to iterate on the Query block.
I would prefer we leave it for later. It's tracked in #25231 and we can discuss all the details there. I also opened #20584 a while ago which covers mostly the same concept that I'm going to close now. |
When inserting a Query block we should explore offering a few starting variations:
We might also want to expose some part of the query config as a second step.
The text was updated successfully, but these errors were encountered: