-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VoiceOver accessibility to contrast-checker #14649
Conversation
I tested it with VoiceOver enabled. It's very aggressive when you try to use custom colors. Every time I pick a new color which doesn't meet criteria triggers the announcement even if this is exactly the same message. It might be a better idea to trigger speak with 3 messages only when they change:
|
Wondering it the message second part is actually useful, both visually and as an audible message:
What is the value added by these sentences? They add cognitive load and make the entire message very long. There's a lot to absorb visually and I'd argue most users won't even get the difference between the two sentences: Wouldn't the first part be enough? I'd consider to display and
Not sure there's the need for a "violation fixed" message. |
I agree. When I was initially testing, it took me some time to realize both error messages were different. I also think error messages shouldn't be this long, because we are expecting a long span of attention from users which users don't usually have. On the other hand, just having "This color combination may be hard for people to read" can induce learned helplessness in users (repeated failure or errors combined with inability to form consistent explanation may induce frustration in users). |
Discussed during today's accessibility bug-scrub, agree to recommend to simplify the messages. |
Let's update it as suggested by @afercia and it should be ready to land :) We also need to have a similar notice with VoiceOver support for Heading level validation as described in the parent issue. I'm saying, in case you are interested in opening another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works great, thanks @AmartyaU for working on it. Nice job 💯
Addresses #10581 (comment)
Description
Added VoiceOver accessibility functionality to contrast-checker
How has this been tested?
Changed background and text color options in color settings and heard warning being announced in addition to it being displayed in all cases
Tested with VoiceOver on Mac in a Chrome browser
Types of changes
New feature (non-breaking change which adds functionality)
Testing
Insert Paragraph block and start playing with its colors with VoiceOver enabled.
Checklist: