Fix e2e test failure screenshots not capturing at the right time #28449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.46 MB ℹ️ View Unchanged
|
|
Somehow when using I've narrowed it down to this following call: await createNewPost({
postType: "wp_template",
title: templateName
});Specifically the I have no idea why it's broken, and I don't have time to investigate it further now, might come back to it later. |
kevin940726
force-pushed
the
update/fix-e2e-failure-screenshots
branch
from
cedeac5
to
d070533
Compare
|
Found the root cause why it was breaking and fixed it. The above error shown in the I know very little about the template API so I don't know whether it's expected or not. Either way, it's already happening in trunk just that it didn't throw any error before. In trunk, we're using the default test runner To mimic the same behavior in |
kevin940726
requested review from
ajitbohra,
gziolo,
nerrad and
ntwb
as code owners
kevin940726
requested review from
tellthemachines,
noisysocks,
talldan,
draganescu and
adamziel
talldan
approved these changes
Apr 19, 2021
gziolo
reviewed
Apr 19, 2021
| @@ -9,6 +9,7 @@ const path = require( 'path' ); | |||
| const { hasBabelConfig } = require( '../utils' ); | |||
|
|
|||
| const jestE2EConfig = { | |||
| testRunner: 'jest-circus/runner', | |||
There was a problem hiding this comment.
Should we update the test runner for unit tests as well for consistency?
I think that's because the lock file in trunk was outdated. I believe it has been resolved recently though. A rebase would fix that.
It's not a new feature though, it was being added in #26664. This PR fixes a bug which caused it to not function correctly when there're async |
|
Good catch! |
It isn't a new feature in the Gutenberg repository. It's a new feature in the |
|
@draganescu Oops, this is not done yet, still have some notes left to do. I'll open another PR. |
7 tasks
This was referenced Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continued from #26664. Fix the screenshots not being captured at the right time.
Specifically, if the tests have
afterEachorafterAlldefined, the screenshots will be captured after these hooks are run. This PR usesjest-circusas the test runner and extendsjest-environment-puppeteerto run the capturing scripts in thetest_fn_failureevent.Not sure why the lock file has so many changes though.
How has this been tested?
Added some intentionally failing tests in https://github.com/WordPress/gutenberg/runs/2358561781 to demo the result. See the failing tests for the stored artifacts. The screenshots captured should correctly point to when it failed.
Types of changes
Bug fix
Checklist: