Media: Use image default size from settings #29966

Mamaduka · 2021-03-18T09:30:49Z

Description

Allows for user-defined image default size setting to be used instead of hardcoded one.

The setting will fallback to the default value, when

image_default_size option isn't defined.
The option doesn't match any registered image size slug for the block editor.

Fixes #8663, #15091 and #20269.

How has this been tested?

Manually

Set image_default_size option to "medium" on wp-admin/options.php page.
Insert new image block.
Media size should be "Medium" by default.

Types of changes

New feature

Checklist:

My code is tested.
My code follows the WordPress code style.
[N/A] My code follows the accessibility standards.
[N/A] I've tested my changes with keyboard and screen readers.
My code has proper inline documentation.
I've included developer documentation if appropriate.
[N/A] I've updated all React Native files affected by any refactorings/renamings in this PR.

gziolo

Nice, I haven't tested but it looks solid. Is there a related ticket opened in WordPress Trac?

This PR needs a rebase.

packages/block-library/src/image/edit.js

gziolo · 2021-03-23T12:30:07Z

lib/editor-settings.php

+	$image_default_size = get_option( 'image_default_size', 'large' );
+	$image_sizes        = wp_list_pluck( $settings['imageSizes'], 'slug' );
+
+	$settings['imageDefaultSize'] = in_array( $image_default_size, $image_sizes, true ) ? $image_default_size : 'large';


I see there is a few places where those settings are filtered ...

Maybe, it would be better to keep them next to imageSizes:

gutenberg/lib/editor-settings.php

Line 49 in 474bb12

'imageSizes' => $available_image_sizes,

It looks like gutenberg_get_common_block_editor_settings isn't used for post editor. Only for site, widgets, and navigation.

I think it makes sense to keep this in the gutenberg_extend_post_editor_settings function for now. Saying this based on DocBlocks of both functions.

Good catch, it's good to keep as is then. I will investigate separately what's the role of gutenberg_get_common_block_editor_settings. FSE and Global Styles add a ton of complexity in the plugin on the PHP side until they are moved to WordPress core.

Adds new 'imageDefaultSize' block editor setting.

Mamaduka · 2021-03-23T16:03:51Z

Is there a related ticket opened in WordPress Trac?

I didn't know I should create one. Is there a contributor guideline when we should create related WordPress Trac tickets?

I've rebased PR. But it looks like checks are failing for unrelated reseasons.

gziolo · 2021-03-23T16:12:22Z

Is there a related ticket opened in WordPress Trac?
I didn't know I should create one. Is there a contributor guideline when we should create related WordPress Trac tickets?

I don't know if there are guidelines, but it's simple to explain. Whenever there is a PHP change that changes/extends the existing behavior in WordPress core it should be backported at some point.

Mamaduka · 2021-03-23T16:14:45Z

Makes sense. I will create a related Trac ticket as well. Thanks for mentioning this.

gziolo · 2021-03-23T16:18:52Z

Related code in the WP Core:
https://github.com/WordPress/wordpress-develop/blob/d271a206dbc87421b221edb2f7acff6ea523fb5d/src/wp-admin/edit-form-blocks.php#L308-L343

paaljoachim · 2021-03-23T17:38:29Z

I made a special download of the Gutenberg plugin. By going to the tab "Checks" (just below the title).
Clicked the Build Gutenberg plugin in the sidebar.
Then downloaded the build as a plugin.
Unzipped it and zipped it up again.
Then uploaded and activated on a local test site.

I added an image and changed the Image size in the sidebar to Medium.
Then add another image to the same page and expected it to automatically have it preselected as Medium.
That did not happen.

Mamaduka · 2021-03-23T18:33:42Z

Hi, @paaljoachim

This PR doesn't add the feature to remember the last selected image size. Instead, it will use user-specified image default size from settings. So it partially fixes #8663.

You can test it using the following steps:

Set image_default_size option to "medium" on wp-admin/options.php page.
Insert new image block.
Media size should be "Medium" by default.

@gziolo, it looks like all the checks are passing now. Is it okay to merge this?

gziolo · 2021-03-23T18:59:08Z

it looks like all the checks are passing now. Is it okay to merge this?

Yep, good to go based on your previous comment clarifying the behavior.

Mamaduka · 2021-03-24T04:05:42Z

Core track ticket: https://core.trac.wordpress.org/ticket/52896.

feastdesignco · 2021-03-24T07:23:26Z

@Mamaduka you're my hero.

Related: WordPress/gutenberg#29966 Add new imageDefaultSize value to block editor settings. Props Mamaduka. Fixes #52896. git-svn-id: https://develop.svn.wordpress.org/trunk@50570 602fd350-edb4-49c9-b593-d223f7449a82

Related: WordPress/gutenberg#29966 Add new imageDefaultSize value to block editor settings. Props Mamaduka. Fixes #52896. Built from https://develop.svn.wordpress.org/trunk@50570 git-svn-id: http://core.svn.wordpress.org/trunk@50183 1a063a9b-81f0-0310-95a4-ce76da25c4cd

Related: WordPress/gutenberg#29966 Add new imageDefaultSize value to block editor settings. Props Mamaduka. Fixes #52896. Built from https://develop.svn.wordpress.org/trunk@50570 git-svn-id: https://core.svn.wordpress.org/trunk@50183 1a063a9b-81f0-0310-95a4-ce76da25c4cd

hypest · 2021-03-24T12:42:30Z

👋 friends, looks like this PR introduced a regression in the native mobile block editor. A fix PR is already in the making.

[N/A] I've updated all React Native files affected by any refactorings/renamings in this PR.

Looking at the changes and the fix, I understand that the regression could have been caught by noticing that DEFAULT_SIZE_SLUG is been used in native.js files so by removing it there would be an issue introduced. Since the PR description checklist already includes a check item exactly for that kind of changes, I wonder if there's been some discussion around why that check item is was not relevant in this PR (since I see it marked as "N/A"). Thanks!

Mamaduka · 2021-03-24T12:56:27Z

Hi, @hypest

Sorry, that's totally my fault. I should have searched block dir manually instead of just trusting the linters.

Is there documentation on how I can test the native mobile block editor? To avoid similar regression in the future.

Thanks,

George

hypest · 2021-03-24T13:25:04Z

Thanks for the understanding @Mamaduka ❤️ .

I think the PR description checklist item can use some rephrasing (and we'll do that in a separate PR. EDIT: here's the PR) as I understand it might not be easy to know which files are those and how one should go about checking them. Sorry for that.

Is there documentation on how I can test the native mobile block editor? To avoid similar regression in the future.

I appreciate the empathy here 🙇‍♂️. There's this React Native based mobile Gutenberg guide linked from the Code contributions guide. It's a bit hard to reach, that's fair, but it can serve as a good starting point. On top of that, always happy to help or give a hand so feel free to ping me or @WordPress/native-mobile. Thanks! 🙇‍♂️

feastdesignco · 2021-07-27T00:41:10Z

Bump. This continues to be a major ongoing issue.

Mamaduka · 2021-07-27T04:51:38Z

Hi, @feastdesignco

Can you provide more details?

This PR got merge into Gutenberg core a while ago, and now it should be part of WP 5.8 as well.

Related: WordPress/gutenberg#29966 Add new imageDefaultSize value to block editor settings. Props Mamaduka. Fixes #52896. Built from https://develop.svn.wordpress.org/trunk@50570 git-svn-id: http://core.svn.wordpress.org/trunk@50183 1a063a9b-81f0-0310-95a4-ce76da25c4cd

bilalmalkoc · 2022-01-08T18:32:58Z

I think it should be available for gallery block also.

feastdesignco · 2022-04-07T22:54:19Z

Hi, @feastdesignco

Can you provide more details?

This PR got merge into Gutenberg core a while ago, and now it should be part of WP 5.8 as well.

Looks like it's functioning now.

Mamaduka requested review from ajlende, ellatrix, spacedmonkey and TimothyBJacobs as code owners March 18, 2021 09:30

Mamaduka added [Feature] Media Anything that impacts the experience of managing media [Block] Image Affects the Image Block [Type] Enhancement A suggestion for improvement. labels Mar 18, 2021

Mamaduka self-assigned this Mar 18, 2021

gziolo approved these changes Mar 23, 2021

View reviewed changes

packages/block-library/src/image/edit.js Outdated Show resolved Hide resolved

gziolo reviewed Mar 23, 2021

View reviewed changes

Mamaduka added 2 commits March 23, 2021 19:16

Media: Use image default size from settings

3c3019c

Adds new 'imageDefaultSize' block editor setting.

Optimize useSelect call

44ea521

Mamaduka force-pushed the add/image-default-size-setting branch from 640231f to 44ea521 Compare March 23, 2021 15:35

Mamaduka merged commit eacc781 into WordPress:trunk Mar 24, 2021

github-actions bot added this to the Gutenberg 10.3 milestone Mar 24, 2021

Mamaduka deleted the add/image-default-size-setting branch March 24, 2021 03:24

This was referenced Mar 24, 2021

Use user-specified defaults for image block, not constants #20269

Closed

'image_default_size' setting doesn't work on Gutenberg #15091

Closed

Mamaduka mentioned this pull request Mar 24, 2021

Add image default size to block editor settings WordPress/wordpress-develop#1117

Closed

fluiddot mentioned this pull request Mar 24, 2021

Image block: Size setting is not displayed #30185

Closed

danielbachhuber mentioned this pull request Jan 6, 2023

Image Block is missing 'srcset' attribute in the editor #46953

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Media: Use image default size from settings #29966

Media: Use image default size from settings #29966

Mamaduka commented Mar 18, 2021

gziolo left a comment •

edited

Loading

gziolo Mar 23, 2021

Mamaduka Mar 23, 2021

gziolo Mar 23, 2021

Mamaduka commented Mar 23, 2021

gziolo commented Mar 23, 2021

Mamaduka commented Mar 23, 2021

gziolo commented Mar 23, 2021

paaljoachim commented Mar 23, 2021

Mamaduka commented Mar 23, 2021

gziolo commented Mar 23, 2021

Mamaduka commented Mar 24, 2021

feastdesignco commented Mar 24, 2021

hypest commented Mar 24, 2021

Mamaduka commented Mar 24, 2021 •

edited

Loading

hypest commented Mar 24, 2021 •

edited

Loading

feastdesignco commented Jul 27, 2021

Mamaduka commented Jul 27, 2021

bilalmalkoc commented Jan 8, 2022

feastdesignco commented Apr 7, 2022

Media: Use image default size from settings #29966

Media: Use image default size from settings #29966

Conversation

Mamaduka commented Mar 18, 2021

Description

How has this been tested?

Types of changes

Checklist:

gziolo left a comment • edited Loading

Choose a reason for hiding this comment

gziolo Mar 23, 2021

Choose a reason for hiding this comment

Mamaduka Mar 23, 2021

Choose a reason for hiding this comment

gziolo Mar 23, 2021

Choose a reason for hiding this comment

Mamaduka commented Mar 23, 2021

gziolo commented Mar 23, 2021

Mamaduka commented Mar 23, 2021

gziolo commented Mar 23, 2021

paaljoachim commented Mar 23, 2021

Mamaduka commented Mar 23, 2021

gziolo commented Mar 23, 2021

Mamaduka commented Mar 24, 2021

feastdesignco commented Mar 24, 2021

hypest commented Mar 24, 2021

Mamaduka commented Mar 24, 2021 • edited Loading

hypest commented Mar 24, 2021 • edited Loading

feastdesignco commented Jul 27, 2021

Mamaduka commented Jul 27, 2021

bilalmalkoc commented Jan 8, 2022

feastdesignco commented Apr 7, 2022

gziolo left a comment •

edited

Loading

Mamaduka commented Mar 24, 2021 •

edited

Loading

hypest commented Mar 24, 2021 •

edited

Loading