Block editor: move layout styles to document head (instead of rendering inline) #32083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
May 21, 2021
| @@ -64,6 +77,8 @@ function Root( { className, children } ) { | |||
| } | |||
| ) } | |||
| > | |||
| { element && | |||
| createPortal( <BlockHeadSlot />, element.ownerDocument.head ) } | |||
There was a problem hiding this comment.
Ideally it would be good if the portal can be created by the component adding the styles, but there's currently no good way to access the block ref (and the owner document). A future refactor should enable that.
|
Size Change: +57 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
youknowriad
added
Backport to WP 6.7 Beta/RC
|
Is it possible to avoid the slots here? Can't we just use |
|
We should also do the same for other hooks that add styles like that. I'm thinking about duotone and elements. |
|
Yes, we should do the same. There's no way to avoid the slot for now I think, because the Block filter doesn't have access to the owner document. |
|
What about the frontend? Do we have the same inline style tags there? should we try to move them as well? |
|
Oh, yes. I didn't think about that :) |
|
Also wonder who the lazy loading of styles currently work? Can we use similar techniques (in the frontend) cc @aristath |
ellatrix
force-pushed
the
move/layout-styles-doc-head
branch
from
6a09a19
to
10c98d2
Compare
|
@youknowriad So this is related to something I'm wondering about. There's a few options where to put the style elements, but for layout style, it seems better to load them in the head because you wouldn't wan't any structural shifts after the content has rendered on the page. Lazy loading the styles seems completely out of the question? |
ellatrix
force-pushed
the
move/layout-styles-doc-head
branch
from
e1fc1e5
to
9a417f5
Compare
|
Lazy loading styles works on the frontend because everything goes through |
ellatrix
force-pushed
the
move/layout-styles-doc-head
branch
from
9a417f5
to
13d81d9
Compare
|
Getting an error with the CPT "lock all" template, which happens when the content is replaced in the store though |
|
Error should be resolved now. Would be good to get this into the release for the template editor. |
oandregal
approved these changes
Jun 28, 2021
ellatrix
force-pushed
the
move/layout-styles-doc-head
branch
from
075e5f9
to
d738caa
Compare
ellatrix
force-pushed
the
move/layout-styles-doc-head
branch
from
d738caa
to
855a9ce
Compare
walbo
reviewed
Jul 8, 2021
lib/block-supports/layout.php
Outdated
Comment on lines
89
to
97
| add_action( | ||
| 'wp_head', | ||
| function () use ( $style ) { | ||
| echo '<style>' . $style . '</style>'; | ||
| } | ||
| ); |
There was a problem hiding this comment.
I do believe using wp_head here will only work for block based themes.
On classic themes the content isn't parsed after wp_head is already runned so this will never get printed. Basically the same reason global styles are loaded in the footer when loading core assets individually. See https://core.trac.wordpress.org/changeset/51309
|
Duotone seems to render fine on save, but this is what I see in the editor.
It seems the |
ellatrix
force-pushed
the
move/layout-styles-doc-head
branch
from
2a39dc3
to
5b55a9d
Compare
|
@ajlende Removed the |
|
Personally, I don't fell confident adding this to 5.8 that late. What do you think about leaving this for a potential 5.8.x and have a couple plugin releases with it? |
|
Sounds good to me. |
ellatrix
added
Backport to WP Minor Release
youknowriad
reviewed
Jul 19, 2021
| @@ -240,13 +242,19 @@ const withDuotoneStyles = createHigherOrderComponent( | |||
|
|
|||
| const className = classnames( props?.className, id ); | |||
|
|
|||
| const element = useContext( Head.context ); | |||
There was a problem hiding this comment.
This breaks the hooks rules (it should be called before the if call above)
youknowriad
reviewed
Jul 19, 2021
| @@ -210,12 +212,18 @@ export const withLayoutStyles = createHigherOrderComponent( | |||
| `wp-container-${ id }` | |||
| ); | |||
|
|
|||
| const element = useContext( Head.context ); | |||
12 tasks
7 tasks
desrosj
pushed a commit
that referenced
this pull request
Aug 30, 2021
desrosj
added a commit
that referenced
this pull request
Sep 1, 2021
* Fix API docs generation (#33384) * Docs: use markdown headings instead of links for API declarations (#33381) * Docs: Run Prettier after updating API in documentation (#33498) (cherry picked from commit 626f233) * Use tabs instead of spaces in block transform doc example (#33549) (cherry picked from commit 8afca1e) * Fix metabox reordering (#30617). * Block editor: don't render layout and duotone styles in between blocks (#32083) * Widgets: Allow HTML tags in description (#33814) * Widgets: Allow HTML tags in description * Use `dangerouslySetInnerHTML` Avoid `<div />` inside the `<p />` tag * Describe by dangerouslySetInnerHTML is used * Use safeHTML * Update comment * Editor: Set 'hide_empty' for the most used terms query (#33457) Don't include terms that aren't assigned to any posts as "most used" terms. * Update widget editor help links to point to the new support article (#33482) * If select-all fires in .editor-post-title__input, end the process.. (#33621) * Writing flow: select all: remove early return for post title (#33699) * Call onChangeSectionExpanded conditionally (#33618) * FontSizePicker: Use number values when the initial value is a number (#33679) * FontSizePicker: Don't use units if the value is a number * Add unit tests * Disable units when we have number values * Fix justification for button block when selected (#33739) * Remove margin setting, auto right conflict with justify buttons * Per review, add little margin back * Add error boundaries to widget screens (#33771) * Add error boundary to edit widgets screen * Add error boundary to customize widgets * Refactor sidebar controls provider to application level so that its state is not lost when re-initializing * Revert "Refactor sidebar controls provider to application level so that its state is not lost when re-initializing" This reverts commit 7d607ff. * Remove rebootability from customize widgets * Remove debug code * Fix insertion point in Widgets editors (#33802) * Default batch processor: Respect the batch endpoint's maxItems (#34280) This updates the default batch processor to make multiple batch requests if the number of requests to process exceeds the number of requests that the batch endpoint can handle. We determine the number of requests that the batch endpoint can handle by making a preflight OPTIONS request to /batch/v1. By default it is 25 requests. See https://make.wordpress.org/core/2020/11/20/rest-api-batch-framework-in-wordpress-5-6/. * Fix button block focus trap after a URL has been added (#34314) * Rework button block link UI to match RichText format implementation * Refine some more, determine visibility by selection and url state * Add e2e test * Also focus rich text when unlinking using a keyboard shortcut * Text for dropdown fields within legacy widgets in the Customizer is off centered (#34076) * Fix ESLint errors reported * Regenerate autogenerated docs * Update the `INSERTER_SEARCH_SELECTOR` path. This is a partial cherry pick of 2356b2d in order to fix the performance tests. Co-authored-by: André <nosolosw@users.noreply.github.com> Co-authored-by: JuanMa <juanma.garrido@gmail.com> Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl> Co-authored-by: Jeff Bowen <jblz@users.noreply.github.com> Co-authored-by: Bruno Ribarić <43731400+ribaricplusplus@users.noreply.github.com> Co-authored-by: Ella van Durpe <4710635+ellatrix@users.noreply.github.com> Co-authored-by: Petter Walbø Johnsgård <petter@dekode.no> Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> Co-authored-by: Daniel Richards <daniel.richards@automattic.com> Co-authored-by: Hiroshi Urabe <mail@torounit.com> Co-authored-by: Kai Hao <kevin830726@gmail.com> Co-authored-by: Marcus Kazmierczak <marcus@mkaz.com> Co-authored-by: Robert Anderson <robert@noisysocks.com> Co-authored-by: Anton Vlasenko <43744263+anton-vlasenko@users.noreply.github.com>
7 tasks
Mamaduka
removed
the
Backport to WP Minor Release
|
Follow-up PR at #38750 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #30500.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).